* [PATCH] mfd: twl4030-power: Drop empty platform remove function
@ 2022-12-12 21:43 Uwe Kleine-König
2023-01-04 17:07 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2022-12-12 21:43 UTC (permalink / raw)
To: Tony Lindgren, Lee Jones; +Cc: linux-omap, linux-kernel, kernel
A remove callback just returning 0 is equivalent to no remove callback
at all. So drop the useless function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/mfd/twl4030-power.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 6b36932263ba..e35b0f788c50 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -953,18 +953,12 @@ static int twl4030_power_probe(struct platform_device *pdev)
return err;
}
-static int twl4030_power_remove(struct platform_device *pdev)
-{
- return 0;
-}
-
static struct platform_driver twl4030_power_driver = {
.driver = {
.name = "twl4030_power",
.of_match_table = of_match_ptr(twl4030_power_of_match),
},
.probe = twl4030_power_probe,
- .remove = twl4030_power_remove,
};
module_platform_driver(twl4030_power_driver);
base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: twl4030-power: Drop empty platform remove function
2022-12-12 21:43 [PATCH] mfd: twl4030-power: Drop empty platform remove function Uwe Kleine-König
@ 2023-01-04 17:07 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-01-04 17:07 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: Tony Lindgren, linux-omap, linux-kernel, kernel
On Mon, 12 Dec 2022, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/mfd/twl4030-power.c | 6 ------
> 1 file changed, 6 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-04 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-12 21:43 [PATCH] mfd: twl4030-power: Drop empty platform remove function Uwe Kleine-König
2023-01-04 17:07 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).