From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B392C38159 for ; Fri, 20 Jan 2023 05:33:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230265AbjATFdi (ORCPT ); Fri, 20 Jan 2023 00:33:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjATFdY (ORCPT ); Fri, 20 Jan 2023 00:33:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B4C97AF29; Thu, 19 Jan 2023 21:28:40 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AD2E5B82166; Thu, 19 Jan 2023 11:13:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CBD5C433EF; Thu, 19 Jan 2023 11:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674126804; bh=JrptjghR/Vgs9p8nXxLUoLdJdd6g9EnHtJeS1PFHDQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=geqj6wRL4wK3/d1U1EN9IXiI1dDG/mMPJ/4P37Z7uTpqkAJwP+h9wRIDNAHQ2ebiE R7hOeFahUu56mK1wEThpL2qqeohi8ML/F9VXlDnHM7DNF2jm3EcS3Qw8iv05BEuVFq 6h6xkiemkCfCJ9cGFev9YqIGHun7NLU1JPFu32S9MzmAMG6NCam2zWXYPfXGnJtynf ZXy+VRtLeP5XlXv4SdPVv1qsZMC3gsMX3UdN/OmQVnWk0FeJ0HrGWdCNednsfxvsZ6 STS4sYlbgoYL8OUIvJKyVkxFzS9InI8sWBtHevkl6H+lu4eIYe9BgFa3Dw0Amydnl1 rkDeNW/VInIOA== Date: Thu, 19 Jan 2023 11:13:21 +0000 From: Mark Brown To: Arnd Bergmann Cc: Arnd Bergmann , Tony Lindgren , Liam Girdwood , Jerome Neanne , Axel Lin , Yang Li , Yang Yingliang , Linux-OMAP , linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH] regulator: tps65219: fix Wextra warning Message-ID: References: <20221215164140.821796-1-arnd@kernel.org> <67efe55d-e5cd-46c1-97e4-c9f3a5884a07@app.fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+SIVaY/fvl0fQGyk" Content-Disposition: inline In-Reply-To: X-Cookie: Serving suggestion. Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org --+SIVaY/fvl0fQGyk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 19, 2023 at 09:07:38AM +0100, Arnd Bergmann wrote: > It looks like you merged another workaround from Randy Dunlap now as > commit 2bbba115c3c9 ("regulator: tps65219: use IS_ERR() to detect an error > pointer"), but I think that one is just as wrong as the one I submitted: > the 'rdev' variable still remains uninitialized, and checking its value > after it has already been used is not helpful. Right, that's just changing the way the result is parsed, it's nothing to do with making sure things are initialised. It's just a coccinelle style thing. --+SIVaY/fvl0fQGyk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPJJc4ACgkQJNaLcl1U h9C6Lgf+MGdWjcr2w5o/s6+Tn+hU9fEAEBbvKquANNH4PIWfbHai88bpEJ3h4P+o D9KYDMRcpJzIkxIvj7f+6tLcFdB7EK1gUFmb919cyQhW5UiZmtNaDAiJNuQLFbzy sx6iJcNAa+TvRFm0zotZ3souT3RPV+cIjSGKqT8cy4r8g3XWH2fQVyRvAUeg3WCw pldKcYZQJrVAAolIUHHMQsT82DwAmOcwogYJGps3PhPNTmAlRZZayqjs1lwuPHja 5JkfzsLpfjWWMFoKnFEavbvM9JUlLN1z02LDLeSSSIEVJXqoDSoYXBvJY9eM4l3a 5BIusGAZA/CZcSRFhvCG/P74ttEfMQ== =+7Er -----END PGP SIGNATURE----- --+SIVaY/fvl0fQGyk--