From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA7BC433DB for ; Mon, 18 Jan 2021 07:49:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60EC922242 for ; Mon, 18 Jan 2021 07:49:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730146AbhARHtf (ORCPT ); Mon, 18 Jan 2021 02:49:35 -0500 Received: from muru.com ([72.249.23.125]:55340 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbhARHte (ORCPT ); Mon, 18 Jan 2021 02:49:34 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8E4D980AE; Mon, 18 Jan 2021 07:48:54 +0000 (UTC) Date: Mon, 18 Jan 2021 09:48:51 +0200 From: Tony Lindgren To: Oskar Holmlund Cc: linux-omap@vger.kernel.org Subject: Re: [am33xx-clocks.dtsi] move ieee5000 ti,gate-clock to a ti,clkctrl? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, * Oskar Holmlund [201230 11:05]: > Hi, > > Is it possible to move > &prcm_clocks { > ... > ieee5000_fck: ieee5000_fck@e4 { > #clock-cells = <0>; > compatible = "ti,gate-clock"; > clocks = <&dpll_core_m4_div2_ck>; > ti,bit-shift = <1>; > reg = <0x00e4>; > }; > > to something like this to better correlate to the TRM 8.1.12.1.40 > CM_PER_IEEE5000_CLKCTRL Register(offset= E4h) ? > Or is there any reason the ieee5000 is a ti,gate-clock? For the clkctrl clocks, we should just use cm base + offset. But somehow we don't have this for ieee5000_clkctrl defined in the include/dt-bindings/clock/am3.h. Regards, Tony