Re: [PATCH v2 02/46] dt-bindings: mfd: ti,am3359-tscadc: Add a yaml description for this MFD

Jonathan Cameron
2021-09-05T11:54:12Z

On Thu, 2 Sep 2021 23:51:00 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> There is a very light description of this MFD in a text file dedicated
> to a touchscreen controller (which is one of the two children of the
> MFD). Here is now a complete yaml description.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Looks good now

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> .../bindings/mfd/ti,am3359-tscadc.yaml | 79 +++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> new file mode 100644
> index 000000000000..b2bff85f2329
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,am3359-tscadc.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,am3359-tscadc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI AM3359 Touchscreen controller/ADC
> +
> +maintainers:
> + - Miquel Raynal <miquel.raynal@bootlin.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: ti,am3359-tscadc
> + - items:
> + - const: ti,am654-tscadc
> + - const: ti,am3359-tscadc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: fck
> +
> + dmas:
> + items:
> + - description: DMA controller phandle and request line for FIFO0
> + - description: DMA controller phandle and request line for FIFO1
> +
> + dma-names:
> + items:
> + - const: fifo0
> + - const: fifo1
> +
> + adc:
> + type: object
> + description: ADC child
> +
> + tsc:
> + type: object
> + description: Touchscreen controller child
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - dmas
> + - dma-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + tscadc@0 {
> + compatible = "ti,am3359-tscadc";
> + reg = <0x0 0x1000>;
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&adc_tsc_fck>;
> + clock-names = "fck";
> + dmas = <&edma 53 0>, <&edma 57 0>;
> + dma-names = "fifo0", "fifo1";
> +
> + tsc {
> + };
> +
> + adc {
> + };
> + };