Re: [PATCH v4 6/8] dt-bindings: mtd: ti,gpmc-onenand: Convert to yaml

Rob Herring
2021-09-21T20:45:21Z

On Tue, Sep 14, 2021 at 03:27:03PM +0300, Roger Quadros wrote:
> Convert gpmc-onenand.txt to ti,gpmc-onenand.yaml.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> .../devicetree/bindings/mtd/gpmc-onenand.txt | 48 -----------
> .../bindings/mtd/ti,gpmc-onenand.yaml | 81 +++++++++++++++++++
> 2 files changed, 81 insertions(+), 48 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
> create mode 100644 Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt b/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
> deleted file mode 100644
> index e9f01a963a0a..000000000000
> --- a/Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
> +++ /dev/null
> @@ -1,48 +0,0 @@
> -Device tree bindings for GPMC connected OneNANDs
> -
> -GPMC connected OneNAND (found on OMAP boards) are represented as child nodes of
> -the GPMC controller with a name of "onenand".
> -
> -All timing relevant properties as well as generic gpmc child properties are
> -explained in a separate documents - please refer to
> -Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt
> -
> -Required properties:
> -
> - - compatible: "ti,omap2-onenand"
> - - reg: The CS line the peripheral is connected to
> - - gpmc,device-width: Width of the ONENAND device connected to the GPMC
> - in bytes. Must be 1 or 2.
> -
> -Optional properties:
> -
> - - int-gpios: GPIO specifier for the INT pin.
> -
> -For inline partition table parsing (optional):
> -
> - - #address-cells: should be set to 1
> - - #size-cells: should be set to 1
> -
> -Example for an OMAP3430 board:
> -
> - gpmc: gpmc@6e000000 {
> - compatible = "ti,omap3430-gpmc";
> - ti,hwmods = "gpmc";
> - reg = <0x6e000000 0x1000000>;
> - interrupts = <20>;
> - gpmc,num-cs = <8>;
> - gpmc,num-waitpins = <4>;
> - #address-cells = <2>;
> - #size-cells = <1>;
> -
> - onenand@0 {
> - compatible = "ti,omap2-onenand";
> - reg = <0 0 0>; /* CS0, offset 0 */
> - gpmc,device-width = <2>;
> -
> - #address-cells = <1>;
> - #size-cells = <1>;
> -
> - /* partitions go here */
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> new file mode 100644
> index 000000000000..42149a9c3a8d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/ti,gpmc-onenand.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OneNAND over Texas Instruments GPMC bus.
> +
> +maintainers:
> + - Tony Lindgren <tony@atomide.com>
> + - Roger Quadros <rogerq@kernel.org>
> +
> +description:
> + GPMC connected OneNAND (found on OMAP boards) are represented
> + as child nodes of the GPMC controller.
> +
> +properties:
> + compatible:
> + const: ti,omap2-onenand
> +
> + reg:
> + items:
> + - description: |
> + Chip Select number, register offset and size of
> + OneNAND register window.
> +
> + "#address-cells": true
> +
> + "#size-cells": true
> +
> + int-gpios:
> + description: GPIO specifier for the INT pin.
> +
> +patternProperties:
> + "@[0-9a-f]+$":
> + $ref: "/schemas/mtd/partitions/partition.yaml"
> +
> +allOf:
> + - $ref: "/schemas/memory-controllers/ti,gpmc-child.yaml"
> +
> +required:
> + - compatible
> + - reg
> + - "#address-cells"
> + - "#size-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + gpmc: memory-controller@6e000000 {
> + compatible = "ti,omap3430-gpmc";
> + reg = <0x6e000000 0x02d0>;
> + interrupts = <20>;
> + gpmc,num-cs = <8>;
> + gpmc,num-waitpins = <4>;
> + clocks = <&l3s_clkctrl>;
> + clock-names = "fck";
> + #address-cells = <2>;
> + #size-cells = <1>;
> +
> + ranges = <0 0 0x01000000 0x01000000>, /* 16 MB for OneNAND */
> + <1 0 0x02000000 0x01000000>; /* 16 MB for smc91c96 */
> +
> + onenand@0,0 {
> + compatible = "ti,omap2-onenand";
> + reg = <0 0 0x20000>; /* CS0, offset 0, IO size 128K */
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "bootloader";
> + reg = <0x00000000 0x00100000>;
> + };
> +
> + partition@1 {

partition@100000

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

> + label = "config";
> + reg = <0x00100000 0x002c0000>;
> + };
> + };
> + };
> --
> 2.17.1
>
>