Re: [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device

Jakub Kicinski
2021-09-29T14:35:55Z

On Wed, 29 Sep 2021 17:31:04 +0300 Leon Romanovsky wrote:
> On Wed, Sep 29, 2021 at 07:26:31AM -0700, Jakub Kicinski wrote:
> > On Wed, 29 Sep 2021 17:16:28 +0300 Leon Romanovsky wrote:
> > > devlink_ops pointer is not constant at this stage, so why can't I copy
> > > reload_* pointers to the "main" devlink ops?
> > >
> > > I wanted to avoid to copy all pointers.
> >
> > Hm. I must be missing a key piece here. IIUC you want to have different
> > ops based on some device property. But there is only one
> >
> > static struct devlink_ops mlx5_devlink_ops;
> >
> > so how can two devlink instances in the system use that and have
> > different ops without a copy?
>
> No, I have two:
> * Base ops - mlx5_devlink_ops
> * Extra reload commands - mlx5_devlink_reload

Still those are global for the driver, no?

What if you have multiple NICs or whatever.