public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: linux-omap@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: Regression with e428e250fde6 on BeagleBoard Rev C2
Date: Thu, 21 Oct 2021 16:58:32 +0300	[thread overview]
Message-ID: <YXFyCIGJj4HnHCpy@atomide.com> (raw)
In-Reply-To: <2e85559a-52fe-f887-51b5-4e7505ebda1e@bitmer.com>

Hi,

* Jarkko Nikula <jarkko.nikula@bitmer.com> [211020 17:53]:
> Hi
> 
> On 9/21/21 10:00 AM, Tony Lindgren wrote:
> > * Jarkko Nikula <jarkko.nikula@bitmer.com> [210920 16:35]:
> >> On 9/20/21 4:34 PM, Tony Lindgren wrote:
> >>> The patch below should take us back to the earlier configuration,
> >>> can you please give it a try?
> >>>
> >> I double checked and unfortunate it doesn't boot at all or give any
> >> output when patch is applied:
> > 
> > Hmm I tested it with copying the beagle timer configuration to omap3.dtsi
> > and things worked for me. If you can, please try adding
> > CONFIG_SERIAL_EARLYCON=y and then also add "debug earlyprintk" to kernel
> > command line. It might show something that I'm not able to reproduce.
> > Maybe there is a bootloader dependency or something like that.
> > 
> As discussed offline recently I triple checked your first patch in this
> thread on top of v5.15-rc6 and using omap2plus_defconfig (has
> CONFIG_SERIAL_EARLYCON=y) and still I'm not able to get any output with
> earlyprintk.

Oh looks like omap3-beagle variants are missing the stdout-path
that allows CONFIG_SERIAL_EARLYCON=y with "earlycon" in the kernel
command line to show early serial debug output. Can you try with the
patch below?

> My kernel command line included "console=ttyO2,115200n8 debug
> earlyprintk=ttyO2,115200n8". Plain v5.15-rc6 boots.

You also need to add "earlycon" to the command line. You could just add
"debug earlycon earlyprintk" if you ever need these and debug is not
too noisy for you :) With the stdout-path, you don't need to specify
earlyprintk.

You should also update your command line to use use ttyS2 instead
of ttyO2 to avoid extra warnings while at it. And make sure your
.config has CONFIG_SERIAL_8250_OMAP=y. These should not affect the
earlycon output AFAIK though.

> Could it be possible the "secure_32k_fck" clock has some system hanging
> issue on my beagle? How I understand from e428e250fde6 ("ARM: dts:
> Configure system timers for omap3") that "secure_32k_fck" is not
> referenced explicitly but your patch here does.

Yes seems like there may be some extra issue on the omap3-beagle
boards. Seeing the earlycon output would be good to see.

Regards,

Tony

8< -----------------
From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Thu, 21 Oct 2021 16:48:30 +0300
Subject: [PATCH] ARM: dts: Add missing stdout-path for omap3-beagle
 variants

This allows seeing early serial console output as long as the kernel
config has CONFIG_SERIAL_EARLYCON=y, and the kernel command line has
earlycon.

Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/omap3-beagle-xm.dts | 4 ++++
 arch/arm/boot/dts/omap3-beagle.dts    | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
--- a/arch/arm/boot/dts/omap3-beagle-xm.dts
+++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
@@ -21,6 +21,10 @@ memory@80000000 {
 		reg = <0x80000000 0x20000000>; /* 512 MB */
 	};
 
+	chosen {
+		stdout-path = &uart3;
+	};
+
 	aliases {
 		display0 = &dvi0;
 		display1 = &tv0;
diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts
--- a/arch/arm/boot/dts/omap3-beagle.dts
+++ b/arch/arm/boot/dts/omap3-beagle.dts
@@ -21,6 +21,10 @@ memory@80000000 {
 		reg = <0x80000000 0x10000000>; /* 256 MB */
 	};
 
+	chosen {
+		stdout-path = &uart3;
+	};
+
 	aliases {
 		display0 = &dvi0;
 		display1 = &tv0;
-- 
2.33.0

  reply	other threads:[~2021-10-21 13:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19 17:41 Regression with e428e250fde6 on BeagleBoard Rev C2 Jarkko Nikula
2021-09-20 13:34 ` Tony Lindgren
2021-09-20 14:52   ` Andreas Kemnade
2021-09-21  7:00     ` Tony Lindgren
2021-09-21 16:25       ` Andreas Kemnade
2021-09-20 16:35   ` Jarkko Nikula
2021-09-21  7:00     ` Tony Lindgren
2021-09-21 17:49       ` Jarkko Nikula
2021-09-22 10:07         ` Tony Lindgren
2021-09-22 17:21           ` Jarkko Nikula
2021-09-23  5:41             ` Tony Lindgren
2021-09-23 18:03               ` Jarkko Nikula
2021-09-24  7:02                 ` Tony Lindgren
2021-09-25 14:55                   ` Jarkko Nikula
2021-09-30  7:04                     ` Tony Lindgren
2021-10-20 17:52       ` Jarkko Nikula
2021-10-21 13:58         ` Tony Lindgren [this message]
2021-10-21 18:10           ` Jarkko Nikula
2021-10-24  6:41             ` Tony Lindgren
2021-09-20 18:19 ` H. Nikolaus Schaller
2021-09-21  7:02   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXFyCIGJj4HnHCpy@atomide.com \
    --to=tony@atomide.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox