From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D4F8C433EF for ; Fri, 29 Oct 2021 06:45:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 666C2610E8 for ; Fri, 29 Oct 2021 06:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232112AbhJ2GsC (ORCPT ); Fri, 29 Oct 2021 02:48:02 -0400 Received: from muru.com ([72.249.23.125]:49686 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232116AbhJ2GsB (ORCPT ); Fri, 29 Oct 2021 02:48:01 -0400 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 08D97807E; Fri, 29 Oct 2021 06:46:07 +0000 (UTC) Date: Fri, 29 Oct 2021 09:45:30 +0300 From: Tony Lindgren To: Tero Kristo Cc: Grygorii Strashko , Geert Uytterhoeven , linux-clk , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" Subject: Re: DRA7 clock question Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Tero Kristo [211029 05:35]: > On 28/10/2021 19:13, Grygorii Strashko wrote: > > On 28/10/2021 18:16, Geert Uytterhoeven wrote: > > > > > >              state <<= __ffs(ad->idlest_mask); > > > > > > state is shifted again? ... > > > > this is probably copy-paste err > > Yeah, this looks like something for someone to fix. The bug has been masked > by the fact that the autoidle_mask for dra7 is always 0x1, meaning the shift > value becomes zero. Heh nice lucky bug there :) Regards, Tony