linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	phone-devel@vger.kernel.org, maemo-leste@lists.dyne.org,
	Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	Dev Null <devnull@uvos.xyz>,
	Andreas Kemnade <andreas@kemnade.info>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	Nitin Gupta <nigupta@nvidia.com>
Subject: Re: Nokia N900 not hitting OFF mode since 5.9 is caused by proactive memory compaction
Date: Fri, 10 Dec 2021 09:20:21 +0200	[thread overview]
Message-ID: <YbL/teuB7qtGhtfL@atomide.com> (raw)
In-Reply-To: <99e25c92-3d2d-0964-0068-651bf44cbf8a@wizzup.org>

Hi,

* Merlijn Wajer <merlijn@wizzup.org> [211210 00:34]:
> Hi,
> 
> I've spent the day bisecting what exact commit prevented the Nokia N900
> from entering the OFF sleep state (between v5.8 and v5.9), and it this
> commit:
> 
> > # first bad commit: [facdaa917c4d5a376d09d25865f5a863f906234a] mm: proactive compaction
> 
> The git tree prior to that commit can idle at about ~27mW in OFF mode,
> and it will often remain in that mode for prolonged amounts of time
> (easily 30 seconds, depending on running userspace). Which the above
> commit applied, the Nokia N900 almost never hits OFF mode any more. This
> would suggest at least to disable CONFIG_COMPACTION, perhaps in
> omap2plus_defconfig? I suspect this might cause idle problems beyond the
> Nokia N900, too.

Nice find, adding Nitin to Cc as well. Nitin, can we somehow avoid the
timers for CONFIG_COMPACTION on an idle system to prevent waking up the
system unnecessarily?

Not sure if sysctl -w vm.compaction_proactiveness=0 is enough to disable
compaction for idle, maybe also the HPAGE_FRAG_CHECK_INTERVAL_MSEC = 500
at ms also causes extra wake-ups?

Regards,

Tony

> Maybe nothing needs to be done here other than disable the config option
> -- but I wanted to share this in case others are trying to figure out
> what happened to their battery life. :-)
> 
> There seem be more power regressions since then (at least on 5.15 there
> is more blocking proper idle), so I'll try to find those as well, but if
> this commit is reverted (or CONFIG_COMPACTION=n is in .config - probably
> easier) on top of v5.9 the system seems to idle fine.
> 
> > # grep ^core_pwrdm /sys/kernel/debug/pm_debug/count | cut -d',' -f2,
> > OFF:16,RET:2
> 
> Hope this helps someone...
> 
> Regards,
> Merlijn
> 
> PS: v5.10 seems to use another 19mW if panel_sony_acx565akm is loaded
> even when display is not active (maybe it doesn't suspend or something?
> - could be fixed later, just noticed it for v5.10). I load it initially
> to idle the display, but until I rmmod the modules, the module uses
> quite a bit more power. This problem is not present in v5.9, so that is
> another thing to chase down I guess... And then v5.15 uses another 12mW
> more, for not yet uncovered reasons)

  reply	other threads:[~2021-12-10  7:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10  0:39 Nokia N900 not hitting OFF mode since 5.9 is caused by proactive memory compaction Merlijn Wajer
2021-12-10  7:20 ` Tony Lindgren [this message]
2021-12-10  9:47   ` Merlijn Wajer
2021-12-16 15:23   ` Merlijn Wajer
2022-01-03 14:44   ` Ivaylo Dimitrov
2022-04-12  9:53     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbL/teuB7qtGhtfL@atomide.com \
    --to=tony@atomide.com \
    --cc=andreas@kemnade.info \
    --cc=devnull@uvos.xyz \
    --cc=hns@goldelico.com \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=maemo-leste@lists.dyne.org \
    --cc=merlijn@wizzup.org \
    --cc=nigupta@nvidia.com \
    --cc=pavel@ucw.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).