From: Tony Lindgren <tony@atomide.com>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Dev Null <devnull@uvos.xyz>, Sebastian Reichel <sre@kernel.org>,
linux-omap@vger.kernel.org, Kevin Hilman <khilman@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] pmic-cpcap: add motorola,droid3 compatible
Date: Mon, 13 Dec 2021 07:57:48 +0200 [thread overview]
Message-ID: <Ybbg3GNwST5Cr9Br@atomide.com> (raw)
In-Reply-To: <20211212230459.13579-2-merlijn@wizzup.org>
* Merlijn Wajer <merlijn@wizzup.org> [211212 23:00]:
> The Droid 3 and the Bionic appear to share the same hardware, so add
> the compatible for the Droid 3 as well.
>
> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
> ---
> arch/arm/mach-omap2/pmic-cpcap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/pmic-cpcap.c b/arch/arm/mach-omap2/pmic-cpcap.c
> index 668dc84fd31e..b9188dde13b9 100644
> --- a/arch/arm/mach-omap2/pmic-cpcap.c
> +++ b/arch/arm/mach-omap2/pmic-cpcap.c
> @@ -245,7 +245,8 @@ int __init omap4_cpcap_init(void)
> voltdm = voltdm_lookup("mpu");
> omap_voltage_register_pmic(voltdm, &omap443x_max8952_mpu);
>
> - if (of_machine_is_compatible("motorola,droid-bionic")) {
> + if (of_machine_is_compatible("motorola,droid-bionic") ||
> + of_machine_is_compatible("motorola,droid3")) {
> voltdm = voltdm_lookup("core");
> omap_voltage_register_pmic(voltdm, &omap_cpcap_core);
>
Looks OK to me, however we should also add all the mapphones to the
Documentation/devicetree/bindings/arm/omap/omap.txt so we can avoid
dtb check warnings. Care to also do a patch for that? Looks like the
others are missing too.
Regards,
Tony
next prev parent reply other threads:[~2021-12-13 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 23:04 [RFC PATCH 0/2] Add support for Motorola Droid 3 (XT862) Merlijn Wajer
2021-12-12 23:04 ` [RFC PATCH 1/2] pmic-cpcap: add motorola,droid3 compatible Merlijn Wajer
2021-12-13 5:57 ` Tony Lindgren [this message]
2021-12-13 10:37 ` Merlijn Wajer
2021-12-15 8:42 ` Tony Lindgren
2021-12-12 23:04 ` [RFC PATCH 2/2] Droid3: add initial DTS Merlijn Wajer
2021-12-13 6:01 ` Tony Lindgren
2021-12-14 21:30 ` Merlijn Wajer
2021-12-19 13:17 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybbg3GNwST5Cr9Br@atomide.com \
--to=tony@atomide.com \
--cc=devnull@uvos.xyz \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=merlijn@wizzup.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).