Re: [PATCH] ARM: OMAP2+: Fix regression for smc calls for vmap stack

[Tony Lindgren <tony@atomide.com>]

* Arnd Bergmann <arnd@arndb.de> [220331 15:25]:
> On Thu, Mar 31, 2022 at 4:42 PM Tony Lindgren <tony@atomide.com> wrote:
> > diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c
> > --- a/arch/arm/mach-omap2/omap-secure.c
> > +++ b/arch/arm/mach-omap2/omap-secure.c
> > @@ -59,8 +59,8 @@ static void __init omap_optee_init_check(void)
> >  u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, u32 arg1, u32 arg2,
> >                                                          u32 arg3, u32 arg4)
> >  {
> > +       static u32 param[5];
> >         u32 ret;
> > -       u32 param[5];
> 
> I think for this one, you do need to use a DEFINE_PER_CPU() to make it
> work when multiple cores run into the function concurrently. This is entered
> on OMAP44xx from irq_notifier() with cmd==CPU_CLUSTER_PM_ENTER
> and from start_secondary(). I suspect that one can show these never happen
> on more than one CPU at a time, but I have not been able to prove that
> myself.

Yeah makes sense. Will post v2.

Regards,

Tony