From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E5DEC433EF for ; Fri, 6 May 2022 01:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387797AbiEFBOs (ORCPT ); Thu, 5 May 2022 21:14:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387795AbiEFBOs (ORCPT ); Thu, 5 May 2022 21:14:48 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9980261296; Thu, 5 May 2022 18:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651799465; x=1683335465; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=r/8ZoH7x8kextBDC9EcGTqQBcpjNzluLvqs0Fv7Xd98=; b=iRx210wxuD9SCk11oM5LRKUR3mNo+Q+0uulJn/iBtZ4c4ZXWIyqQBm76 FzGzosnQerwa9zfjGZ3iOyRXy1SlNKu5ZMs2WQ3+XWPILo695sXqKHDwt qPqDcRECfYD1fqYQxG1xTghHQDmLQ8fx7ABA1HvhXWx91I3ZiZ8m+RUiP umT3L3QcvPLjVkrmCyP9Ls5eMjuHS2fSqV7NO9MX5ZAGBqa6eBAg3u57Y yTq4BEMP+sLy4H/NvghepXTFLzR7xbykYreAy8W9KpRTnd/1EHEFOQiSR 0WMRGo6SHYloX3t8Oi8VgPJMD8FHjdFQjJXE5GYkdGwltmgDyuSKi2AI+ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="331298546" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="331298546" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:11:05 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="537630977" Received: from rli9-dbox.sh.intel.com (HELO rli9-dbox) ([10.239.159.142]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:11:02 -0700 Date: Fri, 6 May 2022 09:09:13 +0800 From: Philip Li To: Dave Hansen Cc: Arnd Bergmann , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Message-ID: References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > On 5/3/22 00:21, Arnd Bergmann wrote: > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > >> From: kernel test robot > >> > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > >> > >> Remove unneeded variable used to store return value. > >> > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > >> > >> Reported-by: kernel test robot > >> Signed-off-by: kernel test robot > > I checked the patch, and unfortunately it is wrong, the current code > > needs to stay. > > The problem is the SET_DMA_ERRATA() macro that accesses the > > local 'errata' variable. > > 0day folks, do we have humans looking over these before they're going > out to the list? If not, can we add some? If so, can the humans get a > little more discerning? ;) Sorry all for the bad patch. So far, we pick up several cocci warnings that we have confidence based on early result analysis and feedback, for these warnings, 0day sends out patch automatically. Thanks for the suggestion Dave, We will change current process to be more conservative and to avoid false patch by adding human analysis. Thanks