From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D7DBC433FE for ; Fri, 6 May 2022 07:34:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389578AbiEFHhx (ORCPT ); Fri, 6 May 2022 03:37:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357143AbiEFHhw (ORCPT ); Fri, 6 May 2022 03:37:52 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDFB25D642; Fri, 6 May 2022 00:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651822450; x=1683358450; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rpRUIxRsFJfMvDD+IjLJpjOz3re74JSzeIb7dhOzr60=; b=FVleBor7rO0q4PHpInmY9Lo9jrCTtVRpIA7uQxl2cBt6UFicfAqWb064 hlMDCWn566FfbPbO7qgR+lIqpzGbGbHEzdgfsjp70LUkpQKLPDkSYQM2k j0VruZhkkEa4dx0ZkijrXBz6Tr9Xc9tG3tEGRGlj3hyMPGOwfkzOQL6TP 218cKy7a2BQJgV9ajLHL2m5hYjySeTybO/qUTRhv4CvdzEehmp6w884z5 MA5IHxR0fd/T3+yrFbA9urEPBJiQ8ONSBP9wAvn8NHiFoeHJt7da2Mjan yC3q0ry86LAxpkp2XeS2D5Ypyjq51btPJnEBr/LmlvRoSQJBAPe7+MmJH Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="248916600" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="248916600" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 00:34:10 -0700 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="585831417" Received: from rli9-dbox.sh.intel.com (HELO rli9-dbox) ([10.239.159.142]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 00:34:07 -0700 Date: Fri, 6 May 2022 15:32:18 +0800 From: Philip Li To: Arnd Bergmann Cc: Dave Hansen , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Message-ID: References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, May 06, 2022 at 09:17:44AM +0200, Arnd Bergmann wrote: > On Fri, May 6, 2022 at 3:09 AM Philip Li wrote: > > On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > > > On 5/3/22 00:21, Arnd Bergmann wrote: > > > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > > >> From: kernel test robot > > > >> > > > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > > >> > > > >> Remove unneeded variable used to store return value. > > > >> > > > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > > > >> > > > >> Reported-by: kernel test robot > > > >> Signed-off-by: kernel test robot > > > > I checked the patch, and unfortunately it is wrong, the current code > > > > needs to stay. > > > > The problem is the SET_DMA_ERRATA() macro that accesses the > > > > local 'errata' variable. > > > > > > 0day folks, do we have humans looking over these before they're going > > > out to the list? If not, can we add some? If so, can the humans get a > > > little more discerning? ;) > > > > Sorry all for the bad patch. So far, we pick up several cocci warnings that > > we have confidence based on early result analysis and feedback, for these > > warnings, 0day sends out patch automatically. > > > > Thanks for the suggestion Dave, We will change current process to be more > > conservative and to avoid false patch by adding human analysis. > > For the returnvar.cocci false-positives, I wonder if it's possible to find them > using another coccinelle helper that detects badly formed macros which > access variables out of scope. I can't think of how this would be expressed, > but maybe someone has an idea. > > Something else went wrong in this particular patch, and I can't explain > how this happened: the subject line contains the name of the wrong platform, > "dove" rather than "omap2". My guess is that this was human error copying > the subject line from another patch, but if this came from a script, you > may want to check how this gets generated. Thanks Arnd, we will investigate this to fix our side issue. And thanks for taking time to check the detail, as mentioned in other reply, we will not send out patch unless it is carefully reviewed/acked by members of 0day. > > Arnd