[PATCH v2] ARM: dts: am33xx: Fix MMCHS0 dma properties

[PATCH v2] ARM: dts: am33xx: Fix MMCHS0 dma properties

[YuTong Chang]

According to technical manual(table 11-24), the DMA of MMCHS0 should be
direct mapped.

Signed-off-by: YuTong Chang <mtwget@gmail.com>
---
v1 -> v2: Cleaned up coding style and addressed review comments

 arch/arm/boot/dts/am33xx-l4.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
index 7da42a5b959c..7e50fe633d8a 100644
--- a/arch/arm/boot/dts/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/am33xx-l4.dtsi
@@ -1502,8 +1502,7 @@ SYSC_OMAP2_SOFTRESET |
 			mmc1: mmc@0 {
 				compatible = "ti,am335-sdhci";
 				ti,needs-special-reset;
-				dmas = <&edma_xbar 24 0 0
-					&edma_xbar 25 0 0>;
+				dmas = <&edma 24 0>, <&edma 25 0>;
 				dma-names = "tx", "rx";
 				interrupts = <64>;
 				reg = <0x0 0x1000>;
-- 
2.36.1

Re: [PATCH v2] ARM: dts: am33xx: Fix MMCHS0 dma properties

[Krzysztof Kozlowski]

On 20/06/2022 14:41, YuTong Chang wrote:
> According to technical manual(table 11-24), the DMA of MMCHS0 should be
> direct mapped.
> 
> Signed-off-by: YuTong Chang <mtwget@gmail.com>
> ---
> v1 -> v2: Cleaned up coding style and addressed review comments

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

Re: [PATCH v2] ARM: dts: am33xx: Fix MMCHS0 dma properties

[Tony Lindgren]

Hi,

* YuTong Chang <mtwget@gmail.com> [220620 15:36]:
> According to technical manual(table 11-24), the DMA of MMCHS0 should be
> direct mapped.

Could this be a bug in the manual assuming mmchs0 is working? Or does this
fix something for you?

Regards,

Tony

Re: [PATCH v2] ARM: dts: am33xx: Fix MMCHS0 dma properties

[Yu-Tung Chang]

Tony Lindgren <tony@atomide.com> 于2022年6月27日周一 18:54写道：

>
> Hi,
>
> * YuTong Chang <mtwget@gmail.com> [220620 15:36]:
> > According to technical manual(table 11-24), the DMA of MMCHS0 should be
> > direct mapped.
>
> Could this be a bug in the manual assuming mmchs0 is working? Or does this
> fix something for you?
>
It modified in commit b5e5090660742c838ddc0b5d1a001e6fe3d5bfd5,
the dma of mmc1 was changed to edma_xbar and did not explain why it should
not match the document.
> Regards,
>
> Tony

Re: [PATCH v2] ARM: dts: am33xx: Fix MMCHS0 dma properties

[Yu-Tung Chang]

Yu-Tung Chang <mtwget@gmail.com> 于2022年7月1日周五 14:04写道：
>
> Tony Lindgren <tony@atomide.com> 于2022年6月27日周一 18:54写道：
>
> >
> > Hi,
> >
> > * YuTong Chang <mtwget@gmail.com> [220620 15:36]:
> > > According to technical manual(table 11-24), the DMA of MMCHS0 should be
> > > direct mapped.
> >
> > Could this be a bug in the manual assuming mmchs0 is working? Or does this
> > fix something for you?
> >
> It modified in commit b5e5090660742c838ddc0b5d1a001e6fe3d5bfd5,
> the dma of mmc1 was changed to edma_xbar and did not explain why it should
> not match the document.
> > Regards,
> >
> > Tony
No evidence of any official documentation error, before submitting
b5e5090660742c838ddc0b5d1a001e6fe3d5bfd5, the mmc1 dma properties
matches the official documentation.

Re: [PATCH v2] ARM: dts: am33xx: Fix MMCHS0 dma properties

[Tony Lindgren]

* Yu-Tung Chang <mtwget@gmail.com> [220701 06:09]:
> Yu-Tung Chang <mtwget@gmail.com> 于2022年7月1日周五 14:04写道：
> >
> > Tony Lindgren <tony@atomide.com> 于2022年6月27日周一 18:54写道：
> >
> > >
> > > Hi,
> > >
> > > * YuTong Chang <mtwget@gmail.com> [220620 15:36]:
> > > > According to technical manual(table 11-24), the DMA of MMCHS0 should be
> > > > direct mapped.
> > >
> > > Could this be a bug in the manual assuming mmchs0 is working? Or does this
> > > fix something for you?
> > >
> > It modified in commit b5e5090660742c838ddc0b5d1a001e6fe3d5bfd5,
> > the dma of mmc1 was changed to edma_xbar and did not explain why it should
> > not match the document.
> > > Regards,
> > >
> > > Tony
> No evidence of any official documentation error, before submitting
> b5e5090660742c838ddc0b5d1a001e6fe3d5bfd5, the mmc1 dma properties
> matches the official documentation.

OK thanks for clarifying. will apply to fixes with a fixes tag.

Regards,

Tony