From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50999C43334 for ; Tue, 28 Jun 2022 06:02:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235044AbiF1GCL (ORCPT ); Tue, 28 Jun 2022 02:02:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245017AbiF1GCJ (ORCPT ); Tue, 28 Jun 2022 02:02:09 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 427AC2CC81 for ; Mon, 27 Jun 2022 23:02:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C15C48106; Tue, 28 Jun 2022 05:56:56 +0000 (UTC) Date: Tue, 28 Jun 2022 09:02:07 +0300 From: Tony Lindgren To: Liang He Cc: p.zabel@pengutronix.de, linux-omap@vger.kernel.org Subject: Re: [PATCH v2] bus/ti-sys: Fix refcount leak bugs Message-ID: References: <20220620145619.4074665-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220620145619.4074665-1-windhl@126.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Liang He [220620 17:51]: > --- a/drivers/bus/ti-sysc.c > +++ b/drivers/bus/ti-sysc.c > @@ -751,6 +751,7 @@ static void sysc_init_stdout_path(struct sysc *ddata) > goto err; > > uart = of_get_property(np, "stdout-path", NULL); > + of_node_put(np); > if (!uart) > goto err; > Looks like you missed another of_node_put() after of_find_node_by_path() in sysc_init_stdout_path(). Please add it and repost. Thanks, Tony