Re: [PATCH] serial: core: Add support for dev_name:0.0 naming for kernel console

Tony Lindgren
2023-07-19T05:28:15Z

* Jiri Slaby <jirislaby@kernel.org> [230719 05:25]:
> On 19. 07. 23, 7:15, Tony Lindgren wrote:
> > +/*
> > + * Add preferred console if configured on kernel command line with naming
> > + * "console=dev_name:0.0".
> > + */
> > +static int serial_core_add_preferred_console(struct uart_driver *drv,
> > + struct uart_port *port)
> > +{
> > + char *port_match, *opt, *name;
> > + int len, ret = 0;
> > +
> > + port_match = kasprintf(GFP_KERNEL, "console=%s:%i.%i",
> > + dev_name(port->dev), port->ctrl_id,
> > + port->port_id);
> > + if (!port_match)
> > + return -ENOMEM;
> > +
> > + opt = strstr(saved_command_line, port_match);
> > + if (!opt)
> > + goto free_port_match;
> > +
> > + len = strlen(port_match);
> > +
> > + if (strlen(opt) > len + 1 && opt[len] == ',')
> > + opt += len + 1;
> > + else
> > + opt = NULL;
> > +
> > + name = kstrdup(drv->dev_name, GFP_KERNEL);
>
> Why do you dup the name here?

I was getting ignoring const warning, but maybe the right solution is
to just use const char *name here.. Let me check.

Regards,

Tony