From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCC1DC83F14 for ; Tue, 29 Aug 2023 14:47:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236222AbjH2Oqm (ORCPT ); Tue, 29 Aug 2023 10:46:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237113AbjH2Oqj (ORCPT ); Tue, 29 Aug 2023 10:46:39 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13C741A6; Tue, 29 Aug 2023 07:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693320391; x=1724856391; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QIr6BJEeXYWl1/G59Qm0C6xyhTPqQoRk2a4GFtsPX54=; b=nyG07AVHA8SuwmCeimOGM1L7XYEbckkH7/e4c+aMseQdWYVL2KznGCGs VGlfaDQIaAhtPpVkhbePABjkTF2Xu0JTGfz1d/IBd3rRhBmYAUXMU6NPi PNyHIUywsWvJ6xaQ8V1jS8guZIyk4Q6dxUxzFWR6XnXoFjfwNLn9QFCB4 58xc8EJydjTzDoxHFLKhvMjI9mUqxkGeZ610VRvB4TZtgUatneQ5TDBAL JAYioyA6OFU3NdxN3JbhfwHjkdW4t0UGtJI/kKElvez96F08Bgs9G+vDz 4cu5jMzCOk2z19vUSt17PaJFfKbr6StcXgvHO9iL8tOcIQWjv9eSy1PBd Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="406379118" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="406379118" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 07:46:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="985368160" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="985368160" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 29 Aug 2023 07:46:26 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qazz7-004uDP-14; Tue, 29 Aug 2023 17:46:25 +0300 Date: Tue, 29 Aug 2023 17:46:24 +0300 From: Andy Shevchenko To: Biju Das Cc: Tony Lindgren , Lee Jones , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table Message-ID: References: <20230828153144.75479-1-biju.das.jz@bp.renesas.com> <20230828153144.75479-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230828153144.75479-3-biju.das.jz@bp.renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Aug 28, 2023 at 04:31:44PM +0100, Biju Das wrote: > Make similar OF and ID table to extend support for ID match using > i2c_match_data(). Currently it works only for OF match tables as the > driver_data is wrong for ID match. ... > While at it, drop the inner leading commas for ID table. Are you sure? ------------------v > - { "palmas", }, > - { "twl6035", }, > - { "twl6037", }, > - { "tps65913", }, > + { "palmas", (kernel_ulong_t)&palmas_data }, > + { "twl6035", (kernel_ulong_t)&palmas_data }, > + { "twl6037", (kernel_ulong_t)&palmas_data }, > + { "tps65913", (kernel_ulong_t)&palmas_data }, -- With Best Regards, Andy Shevchenko