linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node
@ 2024-09-15 19:35 Andreas Kemnade
  2024-09-16 10:36 ` Paul Kocialkowski
  2024-10-04 21:40 ` Kevin Hilman
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Kemnade @ 2024-09-15 19:35 UTC (permalink / raw)
  To: tony, robh, krzk+dt, conor+dt, linux-omap, devicetree,
	linux-kernel, Kevin Hilman
  Cc: Andreas Kemnade, Paul Kocialkowski

dtbs_check was moaning about twl6030-power, use the standard property
instead.
Apparently that twl6030 power snippet slipped in without the
corresponding driver. Now it is handled by the standard property.

CC: Paul Kocialkowski <contact@paulk.fr>
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/ti/omap/omap4-kc1.dts | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
index c6b79ba8bbc91..df874d5f5327f 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
@@ -112,11 +112,7 @@ twl: twl@48 {
 		reg = <0x48>;
 		/* IRQ# = 7 */
 		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */
-
-		twl_power: power {
-			compatible = "ti,twl6030-power";
-			ti,system-power-controller;
-		};
+		system-power-controller;
 	};
 };
 
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node
  2024-09-15 19:35 [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node Andreas Kemnade
@ 2024-09-16 10:36 ` Paul Kocialkowski
  2024-10-04 21:40 ` Kevin Hilman
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Kocialkowski @ 2024-09-16 10:36 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: tony, robh, krzk+dt, conor+dt, linux-omap, devicetree,
	linux-kernel, Kevin Hilman, Paul Kocialkowski

[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]

Hi Andreas,

Le Sun 15 Sep 24, 21:35, Andreas Kemnade a écrit :
> dtbs_check was moaning about twl6030-power, use the standard property
> instead.
> Apparently that twl6030 power snippet slipped in without the
> corresponding driver. Now it is handled by the standard property.

Thanks for the fix! LGTM.

Reviewed-by: Paul Kocialkowski <contact@paulk.fr>

Cheers,

Paul

> CC: Paul Kocialkowski <contact@paulk.fr>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/ti/omap/omap4-kc1.dts | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> index c6b79ba8bbc91..df874d5f5327f 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> @@ -112,11 +112,7 @@ twl: twl@48 {
>  		reg = <0x48>;
>  		/* IRQ# = 7 */
>  		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */
> -
> -		twl_power: power {
> -			compatible = "ti,twl6030-power";
> -			ti,system-power-controller;
> -		};
> +		system-power-controller;
>  	};
>  };
>  
> -- 
> 2.39.2
> 

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expertise in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node
  2024-09-15 19:35 [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node Andreas Kemnade
  2024-09-16 10:36 ` Paul Kocialkowski
@ 2024-10-04 21:40 ` Kevin Hilman
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2024-10-04 21:40 UTC (permalink / raw)
  To: tony, robh, krzk+dt, conor+dt, linux-omap, devicetree,
	linux-kernel, Andreas Kemnade
  Cc: Paul Kocialkowski


On Sun, 15 Sep 2024 21:35:27 +0200, Andreas Kemnade wrote:
> dtbs_check was moaning about twl6030-power, use the standard property
> instead.
> Apparently that twl6030 power snippet slipped in without the
> corresponding driver. Now it is handled by the standard property.
> 
> 

Applied, thanks!

[1/1] ARM: dts: omap4-kc1: fix twl6030 power node
      commit: 59caaade193003e4dcbc92c82e66906ab7558951

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-04 21:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-15 19:35 [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node Andreas Kemnade
2024-09-16 10:36 ` Paul Kocialkowski
2024-10-04 21:40 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).