From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C6821D47B3 for ; Wed, 6 Nov 2024 23:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730934228; cv=none; b=IljaR4jySaVPBnQk8uOdUzmqDakLLl/CDlKMZw5jrGWDcxlUfO395rrITWtCoWUvzpJUI1TPgczLGOljMNt1kH6A00Hu8e5i7pQHG3MSCht3tq8R58s4rL6Llg594+r3Fy06eDonic0vkQ0AMtc6x5hBMWK8Fou483vUM6tUuRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730934228; c=relaxed/simple; bh=2m3lGSb0KPE5zZ2Db41fVxKYqG6pSElwHvTQFR4SvdE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bqewprODHNlUc15Wz0V8O3IA8Px/iMhasukk363jfNOFnqEjWdc2YV9wfMoDVDkRyo3Yf5O6Ho+hjMuihmu474VAKM6kK99u/qGBvy367x5yg4i9+CS1s84DPkKziK1Eh6PapmUZiT0ugqF1dgRDg1MvvQZZnB9KaI/XdcOZ/DA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YlniAT2i; arc=none smtp.client-ip=209.85.166.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YlniAT2i" Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-3a394418442so1568385ab.0 for ; Wed, 06 Nov 2024 15:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1730934226; x=1731539026; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q9d2gmeIZhRgxPs/QSdKvrnEtcel9X904K+JgPPLUDA=; b=YlniAT2iuNJrph7yBz94aFd9UJiJZImS+7hgRg/eFHykZLsr0oeawH86WgDVeWF0Bn hUs4jj2b3vvR0Z8teu5jXa1Wo61Q2JwK98QfOxJnHEGbltma5oF3O3ofbVFMKhl8cnfg CX3E70KrXAY9EBONXHa2KHr5YXQa6G8pmTn9A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730934226; x=1731539026; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q9d2gmeIZhRgxPs/QSdKvrnEtcel9X904K+JgPPLUDA=; b=pX6nuAZCzH9yEYaCmV+w9i5lfUJ4KcGtzIoYVBeijhv77aTm/Ain8JnKofa+mZkPSk cZ2CtzFHIJK3BqWf03HAgpmMr2EeMiiY860PYrHl7M6sf8PyzxR7MYX3U4CzvA/eSYF5 OAayeJdplhb5VL3TAJfXIt64CRHMER4L8QUDv4W6fhg2x43dOBe/KPVFQNsOolm5hiEh sv+Y//pKC9Gt4c2rx+SXIkCsgbZkJzkfm/lX7yD1EmeGNG8rmHNmI92maB6g+jU53x3z tALlkg/ppZRAwOBzFStPYfBQPtF4ht7d4rN+EGxOZvXfwyNtw0wjsCK4F1uJOKshqRPh 2ABw== X-Gm-Message-State: AOJu0YwdXZ0R/JC3DofgRmZ5YyfHMbF1MJUvGYeQ0DAsY91/dCK73QnJ 0nINFb4TjDVlJyUXH+Ki9gVv1lQye0sOLUuy8A2RcxREGrDt0c91/e1oMcX3SqE= X-Google-Smtp-Source: AGHT+IG7HfSv2eyFIIKMy444jXmnmiWXPCH2AIv/dcp59B3nkjEgN8YGo6DZoIeWAXAVpXt23BaENQ== X-Received: by 2002:a92:cd86:0:b0:3a3:35f0:4c19 with SMTP id e9e14a558f8ab-3a6b03b0cd2mr218205245ab.21.1730934226357; Wed, 06 Nov 2024 15:03:46 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4de5f83286fsm33597173.77.2024.11.06.15.03.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Nov 2024 15:03:45 -0800 (PST) Message-ID: Date: Wed, 6 Nov 2024 16:03:44 -0700 Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mfd: omap-usb-tll: handle clk_prepare return code in usbtll_omap_probe To: Karol Przybylski , aaro.koskinen@iki.fi, andreas@kemnade.info, khilman@baylibre.com, rogerq@kernel.org, tony@atomide.com, lee@kernel.org Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20241106223324.479341-1-karprzy7@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241106223324.479341-1-karprzy7@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/6/24 15:33, Karol Przybylski wrote: > clk_prepare() is called in usbtll_omap_probe to fill clk array. > Return code is not checked, leaving possible error condition unhandled. > > Added variable to hold return value from clk_prepare() and return statement > when it's not successful. > > Found in coverity scan, CID 1594680 > > Signed-off-by: Karol Przybylski > --- > drivers/mfd/omap-usb-tll.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c > index 0f7fdb99c809..28446b082c85 100644 > --- a/drivers/mfd/omap-usb-tll.c > +++ b/drivers/mfd/omap-usb-tll.c > @@ -202,7 +202,7 @@ static int usbtll_omap_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct usbtll_omap *tll; > void __iomem *base; > - int i, nch, ver; > + int i, nch, ver, err; > > dev_dbg(dev, "starting TI HSUSB TLL Controller\n"); > > @@ -251,7 +251,11 @@ static int usbtll_omap_probe(struct platform_device *pdev) > if (IS_ERR(tll->ch_clk[i])) > dev_dbg(dev, "can't get clock : %s\n", clkname); > else > - clk_prepare(tll->ch_clk[i]); Braces for the conditional don't looks right. > + err = clk_prepare(tll->ch_clk[i]); > + if (err) { > + dev_err(dev, "Unable to prepare clock\n"); > + return err; Did you check to see if callers handle this new error return in this path? > + } Same here > } > Same here > pm_runtime_put_sync(dev); thanks, -- Shuah