From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: tomi.valkeinen@ti.com, Sumit Semwal <sumit.semwal@ti.com>
Cc: "Guruswamy, Senthilvadivu" <svadivu@ti.com>,
linux-omap@vger.kernel.org, tony@atomide.com
Subject: [omap-for-linus] Un-used DSS regulator data
Date: Mon, 28 Feb 2011 14:20:18 +0530 [thread overview]
Message-ID: <a46904cc06b5f68124e65086b9961d02@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]
Tomi/Sumit,
Today while building Tony's 'omap-for-linus' branch I came
across below build warning.
warning: 'sdp3430_vdda_dac_supply' defined but not used
It seems the DSS regulator data is not being used. Are you missing
any patch which will use it eventually?
If not I propose to remove that data to kill the warning.
Below is the patch for the same. Also attached the same
Regards,
Santosh
>From 037f1122d0bfe77883e6cf937009fd955be253a0 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Mon, 28 Feb 2011 13:54:19 +0530
Subject: [PATCH] omap: 3430sdp-board: Fix warning:
'sdp3430_vdda_dac_supply' defined but not used
The DSS regulator data not seems to be used. So remove the
un-used sdp3430_vdda_dac_supply to avoid build warning
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Senthilvadivu Guruswamy <svadivu@ti.com>
Cc: Sumit Semwal <sumit.semwal@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
arch/arm/mach-omap2/board-3430sdp.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/board-3430sdp.c
b/arch/arm/mach-omap2/board-3430sdp.c
index 8950ecc..19a36a3 100644
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -307,9 +307,6 @@ static struct omap_dss_board_info sdp3430_dss_data = {
.default_device = &sdp3430_lcd_device,
};
-static struct regulator_consumer_supply sdp3430_vdda_dac_supply =
- REGULATOR_SUPPLY("vdda_dac", "omapdss");
-
static struct omap_board_config_kernel sdp3430_config[] __initdata = {
};
--
1.6.0.4
[-- Attachment #2: 0001-omap-3430sdp-board-Fix-warning-sdp3430_vdda_dac_.patch --]
[-- Type: application/octet-stream, Size: 1190 bytes --]
From 037f1122d0bfe77883e6cf937009fd955be253a0 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Mon, 28 Feb 2011 13:54:19 +0530
Subject: [PATCH] omap: 3430sdp-board: Fix warning: 'sdp3430_vdda_dac_supply' defined but not used
The DSS regulator data not seems to be used. So remove the
un-used sdp3430_vdda_dac_supply to avoid build warning
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Senthilvadivu Guruswamy <svadivu@ti.com>
Cc: Sumit Semwal <sumit.semwal@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
arch/arm/mach-omap2/board-3430sdp.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
index 8950ecc..19a36a3 100644
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -307,9 +307,6 @@ static struct omap_dss_board_info sdp3430_dss_data = {
.default_device = &sdp3430_lcd_device,
};
-static struct regulator_consumer_supply sdp3430_vdda_dac_supply =
- REGULATOR_SUPPLY("vdda_dac", "omapdss");
-
static struct omap_board_config_kernel sdp3430_config[] __initdata = {
};
--
1.6.0.4
next reply other threads:[~2011-02-28 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 8:50 Santosh Shilimkar [this message]
2011-02-28 8:59 ` [omap-for-linus] Un-used DSS regulator data Tomi Valkeinen
2011-02-28 9:03 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46904cc06b5f68124e65086b9961d02@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=sumit.semwal@ti.com \
--cc=svadivu@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox