[omap-for-linus] Un-used DSS regulator data

[omap-for-linus] Un-used DSS regulator data

[Santosh Shilimkar]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

Tomi/Sumit,

Today while building Tony's 'omap-for-linus' branch I came
across below build warning.
warning: 'sdp3430_vdda_dac_supply' defined but not used

It seems the DSS regulator data is not being used. Are you missing
any patch which will use it eventually?

If not I propose to remove that data to kill the warning.
Below is the patch for the same. Also attached the same

Regards,
Santosh

>From 037f1122d0bfe77883e6cf937009fd955be253a0 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Mon, 28 Feb 2011 13:54:19 +0530
Subject: [PATCH] omap: 3430sdp-board: Fix warning:
'sdp3430_vdda_dac_supply' defined but not used

The DSS regulator data not seems to be used. So remove the
un-used sdp3430_vdda_dac_supply to avoid build warning

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Senthilvadivu Guruswamy <svadivu@ti.com>
Cc: Sumit Semwal <sumit.semwal@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm/mach-omap2/board-3430sdp.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/board-3430sdp.c
b/arch/arm/mach-omap2/board-3430sdp.c
index 8950ecc..19a36a3 100644
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -307,9 +307,6 @@ static struct omap_dss_board_info sdp3430_dss_data = {
 	.default_device	= &sdp3430_lcd_device,
 };

-static struct regulator_consumer_supply sdp3430_vdda_dac_supply =
-	REGULATOR_SUPPLY("vdda_dac", "omapdss");
-
 static struct omap_board_config_kernel sdp3430_config[] __initdata = {
 };

-- 
1.6.0.4

[-- Attachment #2: 0001-omap-3430sdp-board-Fix-warning-sdp3430_vdda_dac_.patch --]
[-- Type: application/octet-stream, Size: 1190 bytes --]

From 037f1122d0bfe77883e6cf937009fd955be253a0 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Mon, 28 Feb 2011 13:54:19 +0530
Subject: [PATCH] omap: 3430sdp-board: Fix warning: 'sdp3430_vdda_dac_supply' defined but not used

The DSS regulator data not seems to be used. So remove the
un-used sdp3430_vdda_dac_supply to avoid build warning

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Senthilvadivu Guruswamy <svadivu@ti.com>
Cc: Sumit Semwal <sumit.semwal@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm/mach-omap2/board-3430sdp.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
index 8950ecc..19a36a3 100644
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -307,9 +307,6 @@ static struct omap_dss_board_info sdp3430_dss_data = {
 	.default_device	= &sdp3430_lcd_device,
 };
 
-static struct regulator_consumer_supply sdp3430_vdda_dac_supply =
-	REGULATOR_SUPPLY("vdda_dac", "omapdss");
-
 static struct omap_board_config_kernel sdp3430_config[] __initdata = {
 };
 
-- 
1.6.0.4

Re: [omap-for-linus] Un-used DSS regulator data

[Tomi Valkeinen]

Hi,

On Mon, 2011-02-28 at 02:50 -0600, Shilimkar, Santosh wrote:
> Tomi/Sumit,
> 
> Today while building Tony's 'omap-for-linus' branch I came
> across below build warning.
> warning: 'sdp3430_vdda_dac_supply' defined but not used
> 
> It seems the DSS regulator data is not being used. Are you missing
> any patch which will use it eventually?

It was an accidental left over from conflict resolving. I have a patch
in DSS tree which removes the regulator supply.

 Tomi

RE: [omap-for-linus] Un-used DSS regulator data

[Santosh Shilimkar]

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@ti.com]
> Sent: Monday, February 28, 2011 2:30 PM
> To: Shilimkar, Santosh
> Cc: Semwal, Sumit; Guruswamy, Senthilvadivu; linux-
> omap@vger.kernel.org; tony@atomide.com
> Subject: Re: [omap-for-linus] Un-used DSS regulator data
>
> Hi,
>
> On Mon, 2011-02-28 at 02:50 -0600, Shilimkar, Santosh wrote:
> > Tomi/Sumit,
> >
> > Today while building Tony's 'omap-for-linus' branch I came
> > across below build warning.
> > warning: 'sdp3430_vdda_dac_supply' defined but not used
> >
> > It seems the DSS regulator data is not being used. Are you missing
> > any patch which will use it eventually?
>
> It was an accidental left over from conflict resolving. I have a
> patch in DSS tree which removes the regulator supply.
>
Ok.