[PATCH v3 0/2] isp1704_charger: fix powering for N900

[PATCH v3 0/2] isp1704_charger: fix powering for N900

[Kalle Jokiniemi]

This patch set enables powering down the isp1704 usb
tranceiver when not in use.

tested on RX-51 and MeeGo.

Thanks to Felipe Balbi, Sergei Shtylyov, and Heikki Krogerus
for comments.

v3:
* fixed power down handling in isp1704_charger_probe
* removed init_done variable
* changed BUG_ON to WARN_ON
* editorial fixes 

v2: fixed boot issue in the 1/2 patch.

Kalle Jokiniemi (2):
  isp1704_charger: allow board specific powering routine
  RX-51: Enable isp1704 power on/off

 arch/arm/mach-omap2/board-rx51-peripherals.c |   27 ++++++++++++++++++++++-
 drivers/power/isp1704_charger.c              |   22 +++++++++++++++++++
 include/linux/power/isp1704_charger.h        |   29 ++++++++++++++++++++++++++
 3 files changed, 76 insertions(+), 2 deletions(-)
 create mode 100644 include/linux/power/isp1704_charger.h

[PATCH v3 1/2] isp1704_charger: allow board specific powering routine

[Kalle Jokiniemi]

The ISP1704/1707 chip can be put to full power down
state by asserting the CHIP_SEL line. This patch enables
platform or board specific hooks to put the device into
power down mode in case not needed.

This patch is a preparation for enabling this powering
routine in n900 (rx-51) devices.

Thanks to Heikki Krogerus for helping out with the patch.

Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
Cc: Heikki Krogerus <heikki.krogerus@nokia.com>
---
 drivers/power/isp1704_charger.c       |   22 ++++++++++++++++++++++
 include/linux/power/isp1704_charger.h |   29 +++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 0 deletions(-)
 create mode 100644 include/linux/power/isp1704_charger.h

diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
index 2ad9b14..f6d72b4 100644
--- a/drivers/power/isp1704_charger.c
+++ b/drivers/power/isp1704_charger.c
@@ -33,6 +33,7 @@
 #include <linux/usb/ulpi.h>
 #include <linux/usb/ch9.h>
 #include <linux/usb/gadget.h>
+#include <linux/power/isp1704_charger.h>
 
 /* Vendor specific Power Control register */
 #define ISP1704_PWR_CTRL		0x3d
@@ -71,6 +72,18 @@ struct isp1704_charger {
 };
 
 /*
+ * Disable/enable the power from the isp1704 if a function for it
+ * has been provided with platform data.
+ */
+static void isp1704_charger_set_power(struct isp1704_charger *isp, bool on)
+{
+	struct isp1704_charger_data	*board = isp->dev->platform_data;
+
+	if (board->set_power)
+		board->set_power(on);
+}
+
+/*
  * Determine is the charging port DCP (dedicated charger) or CDP (Host/HUB
  * chargers).
  *
@@ -222,6 +235,9 @@ static void isp1704_charger_work(struct work_struct *data)
 
 	mutex_lock(&lock);
 
+	if (event != USB_EVENT_NONE)
+		isp1704_charger_set_power(isp, 1);
+
 	switch (event) {
 	case USB_EVENT_VBUS:
 		isp->online = true;
@@ -269,6 +285,8 @@ static void isp1704_charger_work(struct work_struct *data)
 		 */
 		if (isp->otg->gadget)
 			usb_gadget_disconnect(isp->otg->gadget);
+
+		isp1704_charger_set_power(isp, 0);
 		break;
 	case USB_EVENT_ENUMERATED:
 		if (isp->present)
@@ -394,6 +412,8 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
 	isp->dev = &pdev->dev;
 	platform_set_drvdata(pdev, isp);
 
+	isp1704_charger_set_power(isp, 1);
+
 	ret = isp1704_test_ulpi(isp);
 	if (ret < 0)
 		goto fail1;
@@ -434,6 +454,7 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
 
 	/* Detect charger if VBUS is valid (the cable was already plugged). */
 	ret = otg_io_read(isp->otg, ULPI_USB_INT_STS);
+	isp1704_charger_set_power(isp, 0);
 	if ((ret & ULPI_INT_VBUS_VALID) && !isp->otg->default_a) {
 		isp->event = USB_EVENT_VBUS;
 		schedule_work(&isp->work);
@@ -459,6 +480,7 @@ static int __devexit isp1704_charger_remove(struct platform_device *pdev)
 	otg_unregister_notifier(isp->otg, &isp->nb);
 	power_supply_unregister(&isp->psy);
 	otg_put_transceiver(isp->otg);
+	isp1704_charger_set_power(isp, 0);
 	kfree(isp);
 
 	return 0;
diff --git a/include/linux/power/isp1704_charger.h b/include/linux/power/isp1704_charger.h
new file mode 100644
index 0000000..68096a6
--- /dev/null
+++ b/include/linux/power/isp1704_charger.h
@@ -0,0 +1,29 @@
+/*
+ * ISP1704 USB Charger Detection driver
+ *
+ * Copyright (C) 2011 Nokia Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+
+#ifndef __ISP1704_CHARGER_H
+#define __ISP1704_CHARGER_H
+
+struct isp1704_charger_data {
+	void		(*set_power)(bool on);
+};
+
+#endif
-- 
1.7.1

Re: [PATCH v3 1/2] isp1704_charger: allow board specific powering routine

[Heikki Krogerus]

Hi,

On Tue, Mar 29, 2011 at 04:27:59PM +0300, Kalle Jokiniemi wrote:
> The ISP1704/1707 chip can be put to full power down
> state by asserting the CHIP_SEL line. This patch enables
> platform or board specific hooks to put the device into
> power down mode in case not needed.
> 
> This patch is a preparation for enabling this powering
> routine in n900 (rx-51) devices.
> 
> Thanks to Heikki Krogerus for helping out with the patch.
> 
> Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
> Cc: Heikki Krogerus <heikki.krogerus@nokia.com>

Acked-By: Heikki Krogerus <heikki.krogerus@nokia.com>

> ---
>  drivers/power/isp1704_charger.c       |   22 ++++++++++++++++++++++
>  include/linux/power/isp1704_charger.h |   29 +++++++++++++++++++++++++++++
>  2 files changed, 51 insertions(+), 0 deletions(-)
>  create mode 100644 include/linux/power/isp1704_charger.h

-- 
heikki

[PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[Kalle Jokiniemi]

The isp1704 usb tranceiver is used for charging and can be
disabled when not in use. Provide the powering routine to
the driver via platform data.

Also changed the indent of ".name" variable in rx51_charger_device
definition to use tabs same way as the new ".dev" variable indent.
Put this in the same patch since the indent fix is only needed
when there are multiple members in the struct definition.

Loosely based on earlier patches from Heikki Krogerus in
Nokia N900 maemo kernel.

Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
Cc: Heikki Krogerus <heikki.krogerus@nokia.com>
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |   27 ++++++++++++++++++++++++-
 1 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index bbcb677..fad98ab 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -23,6 +23,7 @@
 #include <linux/gpio.h>
 #include <linux/gpio_keys.h>
 #include <linux/mmc/host.h>
+#include <linux/power/isp1704_charger.h>
 
 #include <plat/mcspi.h>
 #include <plat/board.h>
@@ -52,6 +53,8 @@
 #define RX51_FMTX_RESET_GPIO		163
 #define RX51_FMTX_IRQ			53
 
+#define RX51_USB_TRANSCEIVER_RST_GPIO	67
+
 /* list all spi devices here */
 enum {
 	RX51_SPI_WL1251,
@@ -110,10 +113,30 @@ static struct spi_board_info rx51_peripherals_spi_board_info[] __initdata = {
 	},
 };
 
+static void rx51_charger_set_power(bool on)
+{
+	gpio_set_value(RX51_USB_TRANSCEIVER_RST_GPIO, on);
+}
+
+static struct isp1704_charger_data rx51_charger_data = {
+	.set_power	= rx51_charger_set_power,
+};
+
 static struct platform_device rx51_charger_device = {
-	.name = "isp1704_charger",
+	.name	= "isp1704_charger",
+	.dev	= {
+		.platform_data = &rx51_charger_data,
+	},
 };
 
+static void __init rx51_charger_init(void)
+{
+	WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
+		GPIOF_OUT_INIT_LOW, "isp1704_reset"));
+
+	platform_device_register(&rx51_charger_device);
+}
+
 #if defined(CONFIG_KEYBOARD_GPIO) || defined(CONFIG_KEYBOARD_GPIO_MODULE)
 
 #define RX51_GPIO_CAMERA_LENS_COVER	110
@@ -981,6 +1004,6 @@ void __init rx51_peripherals_init(void)
 	if (partition)
 		omap2_hsmmc_init(mmc);
 
-	platform_device_register(&rx51_charger_device);
+	rx51_charger_init();
 }
 
-- 
1.7.1

Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[Heikki Krogerus]

On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote:
> The isp1704 usb tranceiver is used for charging and can be
> disabled when not in use. Provide the powering routine to
> the driver via platform data.
> 
> Also changed the indent of ".name" variable in rx51_charger_device
> definition to use tabs same way as the new ".dev" variable indent.
> Put this in the same patch since the indent fix is only needed
> when there are multiple members in the struct definition.
> 
> Loosely based on earlier patches from Heikki Krogerus in
> Nokia N900 maemo kernel.
> 
> Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
> Cc: Heikki Krogerus <heikki.krogerus@nokia.com>

Acked-By: Heikki Krogerus <heikki.krogerus@nokia.com>

-- 
heikki

Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[Heikki Krogerus]

Hi,

On Wed, Mar 30, 2011 at 08:08:54AM +0300, ext Heikki Krogerus wrote:
> On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote:
> > The isp1704 usb tranceiver is used for charging and can be
> > disabled when not in use. Provide the powering routine to
> > the driver via platform data.
> > 
> > Also changed the indent of ".name" variable in rx51_charger_device
> > definition to use tabs same way as the new ".dev" variable indent.
> > Put this in the same patch since the indent fix is only needed
> > when there are multiple members in the struct definition.
> > 
> > Loosely based on earlier patches from Heikki Krogerus in
> > Nokia N900 maemo kernel.
> > 
> > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> > Cc: Heikki Krogerus <heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> 
> Acked-By: Heikki Krogerus <heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>

Before Anton takes these, this one needs ack from Tony.

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[Tony Lindgren]

* Heikki Krogerus <heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org> [110413 08:07]:
> Hi,
> 
> On Wed, Mar 30, 2011 at 08:08:54AM +0300, ext Heikki Krogerus wrote:
> > On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote:
> > > The isp1704 usb tranceiver is used for charging and can be
> > > disabled when not in use. Provide the powering routine to
> > > the driver via platform data.
> > > 
> > > Also changed the indent of ".name" variable in rx51_charger_device
> > > definition to use tabs same way as the new ".dev" variable indent.
> > > Put this in the same patch since the indent fix is only needed
> > > when there are multiple members in the struct definition.
> > > 
> > > Loosely based on earlier patches from Heikki Krogerus in
> > > Nokia N900 maemo kernel.
> > > 
> > > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> > > Cc: Heikki Krogerus <heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> > 
> > Acked-By: Heikki Krogerus <heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
> 
> Before Anton takes these, this one needs ack from Tony.

Looks good to me:

Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[kalle.jokiniemi]

Thanks for the ack. Now can we get this patch set in? Anton are you reading this?

If you need refreshed set, I can do that.

- Kalle

 > -----Original Message-----
 > From: ext Tony Lindgren [mailto:tony@atomide.com]
 > Sent: 13. huhtikuuta 2011 9:29
 > To: Krogerus Heikki (Nokia-SD/Helsinki)
 > Cc: Jokiniemi Kalle (Nokia-SD/Tampere); linux-usb@vger.kernel.org;
 > cbouatmailru@gmail.com; balbi@ti.com; sshtylyov@mvista.com;
 > khilman@ti.com; linux-omap@vger.kernel.org; jhnikula@gmail.com
 > Subject: Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
 > 
 > * Heikki Krogerus <heikki.krogerus@nokia.com> [110413 08:07]:
 > > Hi,
 > >
 > > On Wed, Mar 30, 2011 at 08:08:54AM +0300, ext Heikki Krogerus wrote:
 > > > On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote:
 > > > > The isp1704 usb tranceiver is used for charging and can be
 > > > > disabled when not in use. Provide the powering routine to
 > > > > the driver via platform data.
 > > > >
 > > > > Also changed the indent of ".name" variable in rx51_charger_device
 > > > > definition to use tabs same way as the new ".dev" variable indent.
 > > > > Put this in the same patch since the indent fix is only needed
 > > > > when there are multiple members in the struct definition.
 > > > >
 > > > > Loosely based on earlier patches from Heikki Krogerus in
 > > > > Nokia N900 maemo kernel.
 > > > >
 > > > > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
 > > > > Cc: Heikki Krogerus <heikki.krogerus@nokia.com>
 > > >
 > > > Acked-By: Heikki Krogerus <heikki.krogerus@nokia.com>
 > >
 > > Before Anton takes these, this one needs ack from Tony.
 > 
 > Looks good to me:
 > 
 > Acked-by: Tony Lindgren <tony@atomide.com>

RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w]

 > -----Original Message-----
 > From: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-usb-
 > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of ext kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org
 > Sent: 20. huhtikuuta 2011 13:38
 > To: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org; Krogerus Heikki (Nokia-SD/Helsinki);
 > cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
 > Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; balbi-l0cyMroinI0@public.gmane.org; sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org;
 > khilman-l0cyMroinI0@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
 > Subject: RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
 > 
 > Thanks for the ack. Now can we get this patch set in? Anton are you reading
 > this?

Let's try another mail address for Anton...

- Kalle

 > 
 > If you need refreshed set, I can do that.
 > 
 > - Kalle
 > 
 >  > -----Original Message-----
 >  > From: ext Tony Lindgren [mailto:tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org]
 >  > Sent: 13. huhtikuuta 2011 9:29
 >  > To: Krogerus Heikki (Nokia-SD/Helsinki)
 >  > Cc: Jokiniemi Kalle (Nokia-SD/Tampere); linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
 >  > cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; balbi-l0cyMroinI0@public.gmane.org; sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org;
 >  > khilman-l0cyMroinI0@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
 >  > Subject: Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
 >  >
 >  > * Heikki Krogerus <heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org> [110413 08:07]:
 >  > > Hi,
 >  > >
 >  > > On Wed, Mar 30, 2011 at 08:08:54AM +0300, ext Heikki Krogerus wrote:
 >  > > > On Tue, Mar 29, 2011 at 04:28:00PM +0300, Kalle Jokiniemi wrote:
 >  > > > > The isp1704 usb tranceiver is used for charging and can be
 >  > > > > disabled when not in use. Provide the powering routine to
 >  > > > > the driver via platform data.
 >  > > > >
 >  > > > > Also changed the indent of ".name" variable in rx51_charger_device
 >  > > > > definition to use tabs same way as the new ".dev" variable indent.
 >  > > > > Put this in the same patch since the indent fix is only needed
 >  > > > > when there are multiple members in the struct definition.
 >  > > > >
 >  > > > > Loosely based on earlier patches from Heikki Krogerus in
 >  > > > > Nokia N900 maemo kernel.
 >  > > > >
 >  > > > > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
 >  > > > > Cc: Heikki Krogerus <heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
 >  > > >
 >  > > > Acked-By: Heikki Krogerus <heikki.krogerus-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
 >  > >
 >  > > Before Anton takes these, this one needs ack from Tony.
 >  >
 >  > Looks good to me:
 >  >
 >  > Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
 > --
 > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
 > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
 > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[Anton Vorontsov]

On Wed, Apr 20, 2011 at 10:56:51AM +0000, kalle.jokiniemi@nokia.com wrote:
>  > Thanks for the ack. Now can we get this patch set in? Anton are you reading
>  > this?
> 
> Let's try another mail address for Anton...

Sorry for the delay, folks. The two patches are now applied.

Much thanks for your work!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[Keshava Munegowda]

> +
>  static struct platform_device rx51_charger_device = {
> -	.name = "isp1704_charger",
> +	.name	= "isp1704_charger",

I don’t understand what difference between above two lines?
Is your mail client causing this? Or get send-mail doing this?


> +	.dev	= {
> +		.platform_data = &rx51_charger_data,
> +	},
>  };
>
> +static void __init rx51_charger_init(void)
> +{
> +	WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
> +		GPIOF_OUT_INIT_LOW, "isp1704_reset"));
> +
> +	platform_device_register(&rx51_charger_device);
> +}
> +
>  #if defined(CONFIG_KEYBOARD_GPIO) ||
defined(CONFIG_KEYBOARD_GPIO_MODULE)
>
>  #define RX51_GPIO_CAMERA_LENS_COVER	110
> @@ -981,6 +1004,6 @@ void __init rx51_peripherals_init(void)
>  	if (partition)
>  		omap2_hsmmc_init(mmc);
>
> -	platform_device_register(&rx51_charger_device);
> +	rx51_charger_init();
>  }
>
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w]

Hi,

 > -----Original Message-----
 > From: ext Keshava Munegowda [mailto:keshava_mgowda-l0cyMroinI0@public.gmane.org]
 > Sent: 30. maaliskuuta 2011 9:39
 > To: Jokiniemi Kalle (Nokia-MS/Tampere); linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
 > cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
 > Cc: Felipe Balbi; Krogerus Heikki (Nokia-MS/Helsinki); sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org;
 > tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org; Kevin Hilman; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
 > jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
 > Subject: RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
 > 
 > > +
 > >  static struct platform_device rx51_charger_device = {
 > > -	.name = "isp1704_charger",
                            ^space here



 > > +	.name	= "isp1704_charger",
                              ^tab here
 > 
 > I don't understand what difference between above two lines?
 > Is your mail client causing this? Or get send-mail doing this?

No, changed space for tab so that all the members are indented same way.
I had that (apparently obscure) explanation about this in the commit log ;)

 > 
 > 
 > > +	.dev	= {
                          ^tab here also

 > > +		.platform_data = &rx51_charger_data,
 > > +	},
 > >  };
 > >
 > > +static void __init rx51_charger_init(void)
 > > +{
 > > +	WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
 > > +		GPIOF_OUT_INIT_LOW, "isp1704_reset"));
 > > +
 > > +	platform_device_register(&rx51_charger_device);
 > > +}
 > > +
 > >  #if defined(CONFIG_KEYBOARD_GPIO) ||
 > defined(CONFIG_KEYBOARD_GPIO_MODULE)
 > >
 > >  #define RX51_GPIO_CAMERA_LENS_COVER	110
 > > @@ -981,6 +1004,6 @@ void __init rx51_peripherals_init(void)
 > >  	if (partition)
 > >  		omap2_hsmmc_init(mmc);
 > >
 > > -	platform_device_register(&rx51_charger_device);
 > > +	rx51_charger_init();
 > >  }
 > >
 > > --
 > > 1.7.1
 > >
 > > --
 > > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
 > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
 > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[Keshava Munegowda]

> -----Original Message-----
> From: kalle.jokiniemi@nokia.com [mailto:kalle.jokiniemi@nokia.com]
> Sent: Wednesday, March 30, 2011 12:12 PM
> To: keshava_mgowda@ti.com; linux-usb@vger.kernel.org;
cbouatmailru@gmail.com
> Cc: balbi@ti.com; Heikki.Krogerus@nokia.com; sshtylyov@mvista.com;
tony@atomide.com; khilman@ti.com;
> linux-omap@vger.kernel.org; jhnikula@gmail.com
> Subject: RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
>
> Hi,
>
>  > -----Original Message-----
>  > From: ext Keshava Munegowda [mailto:keshava_mgowda@ti.com]
>  > Sent: 30. maaliskuuta 2011 9:39
>  > To: Jokiniemi Kalle (Nokia-MS/Tampere); linux-usb@vger.kernel.org;
>  > cbouatmailru@gmail.com
>  > Cc: Felipe Balbi; Krogerus Heikki (Nokia-MS/Helsinki);
sshtylyov@mvista.com;
>  > tony@atomide.com; Kevin Hilman; linux-omap@vger.kernel.org;
>  > jhnikula@gmail.com
>  > Subject: RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off
>  >
>  > > +
>  > >  static struct platform_device rx51_charger_device = {
>  > > -	.name = "isp1704_charger",
>                             ^space here
>
>
>
>  > > +	.name	= "isp1704_charger",
>                               ^tab here
>  >
>  > I don't understand what difference between above two lines?
>  > Is your mail client causing this? Or get send-mail doing this?
>
> No, changed space for tab so that all the members are indented same way.
> I had that (apparently obscure) explanation about this in the commit log
;)

Then, I am sorry; I couldn't able to notice this!



>
>  >
>  >
>  > > +	.dev	= {
>                           ^tab here also
>
>  > > +		.platform_data = &rx51_charger_data,
>  > > +	},
>  > >  };
>  > >
>  > > +static void __init rx51_charger_init(void)
>  > > +{
>  > > +	WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
>  > > +		GPIOF_OUT_INIT_LOW, "isp1704_reset"));
>  > > +
>  > > +	platform_device_register(&rx51_charger_device);
>  > > +}
>  > > +
>  > >  #if defined(CONFIG_KEYBOARD_GPIO) ||
>  > defined(CONFIG_KEYBOARD_GPIO_MODULE)
>  > >
>  > >  #define RX51_GPIO_CAMERA_LENS_COVER	110
>  > > @@ -981,6 +1004,6 @@ void __init rx51_peripherals_init(void)
>  > >  	if (partition)
>  > >  		omap2_hsmmc_init(mmc);
>  > >
>  > > -	platform_device_register(&rx51_charger_device);
>  > > +	rx51_charger_init();
>  > >  }
>  > >
>  > > --
>  > > 1.7.1
>  > >
>  > > --
>  > > To unsubscribe from this list: send the line "unsubscribe
linux-usb" in
>  > > the body of a message to majordomo@vger.kernel.org
>  > > More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v3 2/2] RX-51: Enable isp1704 power on/off

[kalle.jokiniemi]

Hi,

 > -----Original Message-----
 > From: ext Keshava Munegowda [mailto:keshava_mgowda@ti.com]

<snip>

> >  > > +
 > >  > >  static struct platform_device rx51_charger_device = {
 > >  > > -	.name = "isp1704_charger",
 > >                             ^space here
 > >
 > >
 > >
 > >  > > +	.name	= "isp1704_charger",
 > >                               ^tab here
 > >  >
 > >  > I don't understand what difference between above two lines?
 > >  > Is your mail client causing this? Or get send-mail doing this?
 > >
 > > No, changed space for tab so that all the members are indented same way.
 > > I had that (apparently obscure) explanation about this in the commit log
 > ;)
 > 
 > Then, I am sorry; I couldn't able to notice this!

No problem, you're not the first one to point that out :)

- Kalle

RE: [PATCH v3 0/2] isp1704_charger: fix powering for N900

[kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w]

Hello Anton,

Will you take my patch set in, it has been acked by Heikki, and 
there has been no more comments to be fixed.

- Kalle

 > -----Original Message-----
 > From: Kalle Jokiniemi [mailto:kalle.jokiniemi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org]
 > Sent: 29. maaliskuuta 2011 16:28
 > To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
 > Cc: balbi-l0cyMroinI0@public.gmane.org; Krogerus Heikki (Nokia-MS/Helsinki); sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org;
 > tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org; khilman-l0cyMroinI0@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
 > jhnikula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; Jokiniemi Kalle (Nokia-MS/Tampere)
 > Subject: [PATCH v3 0/2] isp1704_charger: fix powering for N900
 > 
 > This patch set enables powering down the isp1704 usb
 > tranceiver when not in use.
 > 
 > tested on RX-51 and MeeGo.
 > 
 > Thanks to Felipe Balbi, Sergei Shtylyov, and Heikki Krogerus
 > for comments.
 > 
 > v3:
 > * fixed power down handling in isp1704_charger_probe
 > * removed init_done variable
 > * changed BUG_ON to WARN_ON
 > * editorial fixes
 > 
 > v2: fixed boot issue in the 1/2 patch.
 > 
 > Kalle Jokiniemi (2):
 >   isp1704_charger: allow board specific powering routine
 >   RX-51: Enable isp1704 power on/off
 > 
 >  arch/arm/mach-omap2/board-rx51-peripherals.c |   27
 > ++++++++++++++++++++++-
 >  drivers/power/isp1704_charger.c              |   22 +++++++++++++++++++
 >  include/linux/power/isp1704_charger.h        |   29
 > ++++++++++++++++++++++++++
 >  3 files changed, 76 insertions(+), 2 deletions(-)
 >  create mode 100644 include/linux/power/isp1704_charger.h

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html