Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

Catalin Marinas
2010-12-02T17:55:15Z

On Thu, 2010-12-02 at 17:38 +0000, Russell King - ARM Linux wrote:
> On Thu, Dec 02, 2010 at 04:28:40PM +0000, Catalin Marinas wrote:
> > The SCU is part of the core TRM, so I don't expect it to be the same
> > across various MP cores (and A15 is an example).
> >
> > You may want to consolidate functions like scu_prepare_cpus (maybe call
> > it smp_prepare_cpus)
>
> You do realise the function called from architecture independent code is
> called 'smp_prepare_cpus' ?

It indeed looked familiar when I wrote it down :)

> BTW, is it worth making sure that the IC and SCU standby mode bits
> are set for A9 MPCore ?

IMHO I would leave such default settings to the boot monitor as it knows
better whether such feature works or has any benefits. If you want to
always set the bits, it may need trying on a few A9 platforms to make
sure they still work.

--
Catalin