Re: [PATCH net-next v3 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params

Jakub Kicinski
2025-11-10T23:01:36Z

On Fri, 7 Nov 2025 22:14:45 -0800 Saeed Mahameed wrote:
> >+ err = mlx5_nv_param_read_sw_accelerate_conf(dev, mnvda, sizeof(mnvda));
> >+ if (err) {
> >+ NL_SET_ERR_MSG_MOD(extack,
> >+ "Failed to read sw_accelerate_conf mnvda reg");
>
> Plug in the err, NL_SET_ERR_MSG_FMT_MOD(.., .., err);
> other locations as well.

Incorrect. extack should basically be passed to perror()
IOW user space will add strerror(errno) after, anyway.
Adding the errno inside the string is pointless and ugly.