From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2149538B7CD; Tue, 31 Mar 2026 06:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774938342; cv=none; b=gdqx0QbxBEfgCpR0A3yCpcxXcrOkTydowJ7fj92sEhZA7patMjVmSMLp+J/aYoKhlsEj80T3cHwH6pK6N6oYFmTyK0BjxzQ89SPnzU1O7D9LEQoim095oopWKjGsjahKpQ0eqHogj7vYAOI1TlCZS3/DlVYqtbR1qPsb8uBTXz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774938342; c=relaxed/simple; bh=3VFiO/9e0/Dwa/+IPq3LFbEGBlbpH2h2kskMyOOM2wU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f+ff9PV3NCE9CjV4W648M6rlVOdLDgKBlrN05z5Dr1g6kOnTUqnZr4dV6FaT5Nw9pehe+A5IV2rQv6LlyhTeulQOi0rHykawZ8d/GS1e3eD37hKZhpNKBh+S5xudaTsxLnMg+jEDFKYWOJOs1aSPZSxbkZwmP6Crmp7POFBOoPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=M2mIq6aQ; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="M2mIq6aQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774938341; x=1806474341; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3VFiO/9e0/Dwa/+IPq3LFbEGBlbpH2h2kskMyOOM2wU=; b=M2mIq6aQm0Wf2Z5nB/MA+dMiE3IMI6YqKp2tWv0V6X/t72wRFCQfpACP S6U3vW2MWIYnDG3S/hUv7HI9kSOwP4PfKaQiZ4m/DVVq3BsI5pi4wlsuQ WcHKduVZIFgR137Px3hv4AE1RNMaG+e1wctxSKKydBr8/4U2mIiaeS2D7 g25ILUWpQv34mN/BnYmMoMkcmFHtZ6ArVU8vRcTYNT08HMFvTCm0Tl3KI Y1Hesl39EuC8j6OkUOWdhRNEyMztUDBelqJuU4qOItuClxR6J5dM3D9n7 w3aBwfnae06fSWUoQhI2AqS2o+s8r2IhYcMJTf3CrlGkCyXj0hgDZsvgN A==; X-CSE-ConnectionGUID: o70gKDI/TGiw/DeIF7QLBw== X-CSE-MsgGUID: j7FETsUAR2yOhTF2wB9Yig== X-IronPort-AV: E=McAfee;i="6800,10657,11744"; a="93323388" X-IronPort-AV: E=Sophos;i="6.23,151,1770624000"; d="scan'208";a="93323388" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 23:25:41 -0700 X-CSE-ConnectionGUID: tM5AvxKvTS20bU+YYeM05g== X-CSE-MsgGUID: XLXLMmThTjauDlTqrccrPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,151,1770624000"; d="scan'208";a="230730554" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.209]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 23:25:35 -0700 Date: Tue, 31 Mar 2026 09:25:33 +0300 From: Andy Shevchenko To: Dmitry Torokhov Cc: Bartosz Golaszewski , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Daniel Scally , Heikki Krogerus , Sakari Ailus , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Kevin Hilman , Arnd Bergmann , brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v4 2/3] driver core: make software nodes available earlier Message-ID: References: <20260330-nokia770-gpio-swnodes-v4-0-b68592e977d0@oss.qualcomm.com> <20260330-nokia770-gpio-swnodes-v4-2-b68592e977d0@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Mar 30, 2026 at 02:46:45PM -0700, Dmitry Torokhov wrote: > On Mon, Mar 30, 2026 at 11:24:45PM +0300, Andy Shevchenko wrote: > > On Mon, Mar 30, 2026 at 02:40:47PM +0200, Bartosz Golaszewski wrote: ... > > > -static void __exit software_node_exit(void) > > > -{ > > > - ida_destroy(&swnode_root_ids); > > > - kset_unregister(swnode_kset); > > > } > > > -__exitcall(software_node_exit); > > > > Why? What's wrong with the __exitcall? > > It's dead code. Always was, always will be. > > Maybe split in a separate patch, but I sometimes feel the idea of "one > change" is taken to extreme and adds to both developer's and maintainers > burden by needing to keep track of extra patches. Why does __exitcall() exist then? It's also used in other places. I think it's generally good to have a possibility to clean up after run. A bit of archaeology: The first time it appeared was in the bcc2152647b8 ("Import 2.4.0-test3pre3"). Then somehow spread a bit (but not much). -- With Best Regards, Andy Shevchenko