From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <john.stultz@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>,
lkml <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>, Nishanth Menon <nm@ti.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] clocksource: Allow toggling between runtime and persistent clocksource for idle
Date: Mon, 6 Jul 2015 19:34:54 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507061931570.3916@nanos> (raw)
In-Reply-To: <CALAqxLXUWE8HmVW+i=qjdFnGOfrVNM+vRgEdtpp2HS6pzxAKEQ@mail.gmail.com>
On Mon, 6 Jul 2015, John Stultz wrote:
> On Mon, Jul 6, 2015 at 12:12 AM, Tony Lindgren <tony@atomide.com> wrote:
> > Some persistent clocksources can be on a slow external bus. For shorter
> > latencies for RT use, let's allow toggling the clocksource during idle
> > between a faster non-persistent runtime clocksource and a slower persistent
> > clocksource.
>
> So yea, as Thomas mentioned, this will cause problems for timekeeping
> accuracy, since we end up resetting the ntp state when we change
> clocksource (additionally you gain a bit of error each time you switch
> clocksources). So you'll most likely see trouble w/ ntpd steering the
> clock.
>
> I'm not sure its quite clear in the description as to the need here.
> Could you expand a bit as to the rational for why? I assume it has to
> do with you have a high-res clocksource that is good for fine-grained
> clock_gettime() calls, but wraps quickly, making it poor for long idle
> times. So you're trying to swap to a less fine grained clocksource
> that won't wrap so fast?
>
> The persistent-clock-like name muddies things further, since the
> persistent-clock is used for suspend, while it looks like this is just
> for idle times.
Though that are idle states where the cpu is powered off so the fast
clock source is powered off as well....
We all know how well that works from the x86/TSC horror. It's just the
same thing again with a different arch prefix.
Thanks,
tglx
next prev parent reply other threads:[~2015-07-06 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 7:12 [PATCH] clocksource: Allow toggling between runtime and persistent clocksource for idle Tony Lindgren
2015-07-06 14:18 ` Thomas Gleixner
2015-07-06 15:22 ` Tony Lindgren
2015-07-06 15:46 ` Thomas Gleixner
2015-07-06 16:42 ` Tony Lindgren
2015-07-06 17:51 ` John Stultz
2015-07-07 10:24 ` Tony Lindgren
2015-07-06 17:28 ` John Stultz
2015-07-06 17:34 ` Thomas Gleixner [this message]
2015-07-06 17:53 ` John Stultz
2015-07-07 10:33 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507061931570.3916@nanos \
--to=tglx@linutronix.de \
--cc=balbi@ti.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tony@atomide.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox