From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 8) Date: Thu, 27 May 2010 19:00:47 +0200 (CEST) Message-ID: References: <20100526120242.5c9b73ad@schatten.dmk.lab> <20100526133721.602633b2@schatten.dmk.lab> <20100526142430.327ccbc4@schatten.dmk.lab> <20100526141612.3e2e0443@lxorguk.ukuu.org.uk> <20100527003943.07c17f85@lxorguk.ukuu.org.uk> <20100527140655.GA28048@srcf.ucam.org> <20100527155201.GA31937@srcf.ucam.org> <20100527171615.15a1fd3d@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from www.tglx.de ([62.245.132.106]:59411 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758092Ab0E0RCI (ORCPT ); Thu, 27 May 2010 13:02:08 -0400 In-Reply-To: <20100527171615.15a1fd3d@lxorguk.ukuu.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Alan Cox Cc: Matthew Garrett , =?ISO-8859-15?Q?Arve_Hj=F8nnev=E5g?= , Florian Mickler , Vitaly Wool , Peter Zijlstra , LKML , Paul@smtp1.linux-foundation.org, felipe.balbi@nokia.com, Linux OMAP Mailing List , Linux PM On Thu, 27 May 2010, Alan Cox wrote: > That's all your need to do it right. > > In kernel yes your device driver probably does need to say things like > 'Don't go below C6 for a moment' just as a high speed serial port might > want to say 'Nothing over 10mS please' > > I can't speak for Thomas, but I'm certainly not arguing that you don't > need something that looks more like the blocker side of the logic *in > kernel*, because there is stuff that you want to express which isn't tied > to the task. I'm not opposed, but yes it needs to be expressed in quantifiable terms, i.e. wakeup latency. That's just contributing to the global QoS state of affairs even if it is not tied to a particular task. And that allows the driver to be intelligent about it. The serial port at 9600 has definitely different requirements than at 115200. But that's quite a different concept than the big hammer approach of the blockers. Thanks, tglx