linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Pitre <nico@fluxnic.net>
To: Ruslan Bilovol <ruslan.bilovol@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, tony@atomide.com,
	linux@arm.linux.org.uk, eduardo.valentin@ti.com
Subject: Re: [RFC PATCH v3 1/2] ARM: kernel: update cpuinfo to print SoC model name
Date: Wed, 30 Jan 2013 14:07:53 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1301301402330.6300@xanadu.home> (raw)
In-Reply-To: <1359558091-29251-2-git-send-email-ruslan.bilovol@ti.com>

On Wed, 30 Jan 2013, Ruslan Bilovol wrote:

> Currently, reading /proc/cpuinfo provides userspace with CPU ID of
> the CPU carrying out the read from the file.
> Userspace using this information may decide what module
> to load or how to configure some specific (and processor-depended)
> settings or so.
> However, since really different SoCs can share same ARM core,
> this information currently is not so useful.
> For example, TI OMAP4460 and OMAP4470 SoCs show the same
> information in the /proc/cpuinfo whereas they are different.
> Since in most cases ARM CPU is a part of some system on a chip (SoC),
> the "cpuinfo" file looks like exactly that place, where this
> information have to be displayed.
> 
> So added new line "SoC name" in the "cpuinfo" output for system
> on a chip name. It is placed between CPU information and machine
> information, so the file structure looks gracefully (CPU-SoC-Hardware)
> 
> Example:
> 
> / # cat proc/cpuinfo
> [...]
> CPU variant     : 0x2
> CPU part        : 0xc09
> CPU revision    : 10
> 
> SoC name        : OMAP4470
> 
> Hardware        : OMAP4 Blaze Tablet

Please remove that extra blank line between "SoC name" and "Hardware".  
The blank line after "CPU revision" is fine.

Also, please rename this to "System name".  Not all systems are "on 
chip".  By using "System name" this is more universally useful.


Nicolas

  reply	other threads:[~2013-01-30 19:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 15:01 [RFC PATCH v3 0/2] ARM: update cpuinfo to print SoC model name Ruslan Bilovol
2013-01-30 15:01 ` [RFC PATCH v3 1/2] ARM: kernel: " Ruslan Bilovol
2013-01-30 19:07   ` Nicolas Pitre [this message]
2013-01-30 20:37     ` Matt Sealey
2013-01-30 21:02       ` Nicolas Pitre
2013-01-30 23:24     ` Russell King - ARM Linux
2013-01-31  0:33       ` Nicolas Pitre
2013-01-31 11:50       ` Ruslan Bilovol
2013-01-30 23:18   ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-30 15:01 ` [RFC PATCH v3 2/2] ARM: OMAP4: setup SoC model name during ID initialisation Ruslan Bilovol
2013-01-30 15:57   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1301301402330.6300@xanadu.home \
    --to=nico@fluxnic.net \
    --cc=eduardo.valentin@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=ruslan.bilovol@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).