From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Paul Walmsley <paul@pwsan.com>,
Balaji T Krishnamoorthy <balajitk@ti.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org
Subject: RE: State of SDP4430 platform
Date: Tue, 18 Jan 2011 12:23:18 +0530 [thread overview]
Message-ID: <b0ab62fa0152a383103914db34758d0c@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101171611270.13225@utopia.booyaka.com>
(+ Balaji TK)
> -----Original Message-----
> From: Paul Walmsley [mailto:paul@pwsan.com]
> Sent: Tuesday, January 18, 2011 4:49 AM
> To: Santosh Shilimkar
> Cc: Russell King - ARM Linux; linux-omap@vger.kernel.org
> Subject: RE: State of SDP4430 platform
>
> On Mon, 17 Jan 2011, Santosh Shilimkar wrote:
>
> > The I2C timeout issue I could reproduce on my ES1.0 board. It's
> ES1.0
> > specific issue because I2C burst mode wasn't fuctional on it. Twl
> RTC
> > driver uses I2C burst mode and hence it times out. Other TWL I2C
> > module has no such issue.
> > The pull work-around we tried was not reliable hence it was
> dropped.
> >
> > In short the TWL RTC driver won't function on ES1.0. Apart from
> that
> > rest of the I2C clients should work as usual.
>
> Looks like the IRQ handling code uses it too:
>
> $ egrep -r 'twl_i2c_(write|read)\(' drivers/ | egrep -v twl-core |
> egrep -v 4030
> drivers/mfd/twl6030-irq.c: ret =
> twl_i2c_read(TWL_MODULE_PIH, sts.bytes,
> drivers/mfd/twl6030-irq.c: ret =
> twl_i2c_write(TWL_MODULE_PIH, sts.bytes,
> drivers/mfd/twl6030-irq.c: ret = twl_i2c_write(TWL_MODULE_PIH,
> &mask[0],
> drivers/mfd/twl6030-irq.c: ret = twl_i2c_write(TWL_MODULE_PIH,
> &mask[0],
> drivers/mfd/twl6030-irq.c: ret = twl_i2c_write(TWL_MODULE_PIH,
> &mask[0],
> drivers/rtc/rtc-twl.c: ret = twl_i2c_read(TWL_MODULE_RTC,
rtc_data,
> drivers/rtc/rtc-twl.c: ret = twl_i2c_write(TWL_MODULE_RTC,
> rtc_data,
> drivers/rtc/rtc-twl.c: ret = twl_i2c_read(TWL_MODULE_RTC,
rtc_data,
> drivers/rtc/rtc-twl.c: ret = twl_i2c_write(TWL_MODULE_RTC,
> alarm_data,
> $
>
> I'd assume this also would affect other, non-TWL, I2C endpoints, no?
>
> Sounds like a platform_data flag should be passed into the I2C
> driver code
> to indicate that burst transactions are buggy on OMAP4430ES1.
>
As per Balaji other phoenix I2C modules works fine except RTC.
In that case RTC needed some patching.
Regards,
Santosh
next prev parent reply other threads:[~2011-01-18 6:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 1:09 State of SDP4430 platform Russell King - ARM Linux
2011-01-16 6:06 ` Paul Walmsley
2011-01-16 6:25 ` Santosh Shilimkar
2011-01-17 10:07 ` Santosh Shilimkar
2011-01-17 23:19 ` Paul Walmsley
2011-01-18 6:53 ` Santosh Shilimkar [this message]
2011-01-19 15:26 ` Krishnamoorthy, Balaji T
2011-01-19 23:26 ` Paul Walmsley
2011-01-19 23:27 ` Paul Walmsley
2011-02-07 23:49 ` Paul Walmsley
2011-03-02 18:50 ` Paul Walmsley
2011-03-03 15:23 ` Krishnamoorthy, Balaji T
2011-02-06 9:49 ` Russell King - ARM Linux
2011-02-07 6:05 ` Santosh Shilimkar
2011-02-07 6:58 ` Krishnamoorthy, Balaji T
2011-02-07 8:18 ` Gulati, Shweta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0ab62fa0152a383103914db34758d0c@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=balajitk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).