Re: [PATCH 3/5] ARM: twd: Add context save restore support

Colin Cross
2011-01-25T18:44:53Z

On Tue, Jan 25, 2011 at 3:29 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Jan 24, 2011 at 11:39:13PM -0800, Colin Cross wrote:
>> This doesn't work for oneshot timers if the TWD_TIMER_CONTROL register
>> gets reset by cpu idle between twd_set_mode and twd_set_next_event.
>> Shadowing ctrl in a percpu variable and rewriting it during every call
>> to twd_set_next_event does work, but that's not much different, and a
>> little less efficient, than just saving and restoring the control and
>> load registers in idle.  It does have the advantage that platforms
>> don't need any extra calls.
>
> BTW, do you think the patch is, nevertheless, an improvement and something
> we should do?  If so, please can I have your ack for it?

This patch does work after adding the missing clockevent broadcasts to
the Tegra idle driver, and allows me to remove all references to twd
registers in the idle and suspend code, so:
Acked-by: Colin Cross <ccross@android.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html