RE: [PATCH 4/5] ARM: scu: Move register defines to header file

Santosh Shilimkar
2011-02-04T10:46:09Z

> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk]
> Sent: Friday, February 04, 2011 4:11 PM
> To: Santosh Shilimkar
> Cc: catalin.marinas@arm.com; linus.ml.walleij@gmail.com; linux-
> omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> ccross@android.com
> Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header
> file
>
> On Tue, Jan 25, 2011 at 11:53:35PM +0530, Santosh Shilimkar wrote:
> > After fixing the 3rd version for base address break, I was able to
> > use this patch and test it. Seems to work. SMC related stuff can
> > be ignored because OMAP4 ES1.0 doesn't have functional PM hardware
> > support.
>
> I think I'd prefer to do as the other functions do, and pass in the
> scu base address from the platform code. It's potentially more
> efficient for platforms which have a fixed SCU base address.
Ok. I can fix that