Re: [PATCH 4/5] ARM: scu: Move register defines to header file

Russell King - ARM Linux
2011-02-07T10:18:47Z

On Mon, Feb 07, 2011 at 03:21:44PM +0530, Santosh Shilimkar wrote:
> > -----Original Message-----
> > From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk]
> > Sent: Friday, February 04, 2011 5:01 PM
> > To: Santosh Shilimkar
> > Cc: catalin.marinas@arm.com; linus.ml.walleij@gmail.com; linux-
> > omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > ccross@android.com
> > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header
> > file
> >
> [.....]
>
> > 8<------
> > Subject: [PATCH] ARM: smp: add function to set WFI low-power mode
> > for SMP CPUs
> >
> > Add a function to set the SCU low-power mode for SMP CPUs. This
> > centralizes this functionality rather than having to expose the
> > SCU register definitions to each platform.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> > arch/arm/include/asm/smp_scu.h | 5 +++++
> > arch/arm/kernel/smp_scu.c | 24 ++++++++++++++++++++++++
> > 2 files changed, 29 insertions(+), 0 deletions(-)
> >
>
> [....]
>
> > diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c
> > index 9ab4149..0ba329a 100644
> > --- a/arch/arm/kernel/smp_scu.c
> > +++ b/arch/arm/kernel/smp_scu.c
> > @@ -50,3 +50,27 @@ void __init scu_enable(void __iomem *scu_base)
> > */
> > flush_cache_all();
> > }
> > +
> > +/*
> > + * Set the executing CPUs power mode as defined. This will be in
> > + * preparation for it executing a WFI instruction.
> > + *
> > + * This function must be called with preemption disabled, and as it
> > + * has the side effect of disabling coherency, caches must have
> > been
> > + * flushed. Interrupts must also have been disabled.
> > + */
> > +int scu_power_mode(void __iomem *scu_base, unsigned int mode)
> > +{
> > + unsigned int val;
> > + int cpu = smp_processor_id();
> > + int shift;
> shift is unused with this version now so I am removing it.

Yes, I noticed that - it's gone in the version I merged into my tree.