Re: [PATCH 3/5] ARM: twd: Add context save restore support

Russell King - ARM Linux
2011-01-25T11:30:27Z

On Mon, Jan 24, 2011 at 11:39:13PM -0800, Colin Cross wrote:
> This doesn't work for oneshot timers if the TWD_TIMER_CONTROL register
> gets reset by cpu idle between twd_set_mode and twd_set_next_event.
> Shadowing ctrl in a percpu variable and rewriting it during every call
> to twd_set_next_event does work, but that's not much different, and a
> little less efficient, than just saving and restoring the control and
> load registers in idle. It does have the advantage that platforms
> don't need any extra calls.

BTW, do you think the patch is, nevertheless, an improvement and something
we should do? If so, please can I have your ack for it?

Thanks.