From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thor Thayer Subject: Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Date: Tue, 1 Aug 2017 13:57:59 -0500 Message-ID: References: <1499140415-31677-1-git-send-email-yamada.masahiro@socionext.com> Reply-To: thor.thayer@linux.intel.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1499140415-31677-1-git-send-email-yamada.masahiro@socionext.com> Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org To: Masahiro Yamada , linux-gpio@vger.kernel.org Cc: Grygorii Strashko , Linus Walleij , Andy Shevchenko , William Breathitt Gray , Ray Jui , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , David Cohen , Scott Branden , linux-acpi@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Thierry Reding , Jonathan Hunter , Alexander Shiyan , Michal Simek , Kevin Hilman , linux-tegra@vger.kernel.org, Joel Stanley , linux-omap@vger.kernel.org, linux-arm-k List-Id: linux-omap@vger.kernel.org On 07/03/2017 10:53 PM, Masahiro Yamada wrote: > Some of include directives in include/linux/gpio/driver.h are > unneeded because the header does not need to know the content of > struct device, irq_chip, etc. Just declare they are structures. > > On the other hand, and > turned out to be necessary for irq_flow_handler_t and spinlock_t, > respectively. > > Each driver should include what it needs without relying on what is > implicitly included from . This will cut down > unnecessary header parsing. > > Signed-off-by: Masahiro Yamada > --- > > drivers/gpio/gpio-altera-a10sr.c | 2 ++ > drivers/gpio/gpio-altera.c | 3 +++ For the Altera GPIO files: Acked-by: Thor Thayer