From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH 4/6] mfd: dm355evm_msp: Refactoring for add_child() Date: Tue, 28 Jun 2016 17:40:44 +0200 Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <20160608111442.GB14888@dell> <75c1cc23-3a2d-db78-d0f2-b5934b18e828@users.sourceforge.net> <20160628150725.GL24982@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160628150725.GL24982@dell> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones Cc: Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-omap@vger.kernel.org >> @@ -222,19 +222,21 @@ static struct device *add_child(struct i2c_client *client, const char *name, >> status = platform_device_add_resources(pdev, &r, 1); >> if (status < 0) { >> dev_dbg(&pdev->dev, "can't add irq\n"); >> - goto err; >> + goto put_device; >> } >> } >> >> status = platform_device_add(pdev); >> > > Remove this line too. Do you propose the deletion of a blank line here? Did you skip this update suggestion while the other patches were finally accepted? Regards, Markus