From: Anand Gadiyar <gadiyar@ti.com>
To: Nishanth Menon <nm@ti.com>, Vishwanath Sripathy <vishwanath.bs@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@ti.com>
Subject: RE: do we need CHIP_GE_OMAP3630ES1in .oc? (was Re: [PATCH 02/19] omap3630: hwmod: sr: enable for higher ES)
Date: Mon, 21 Feb 2011 11:20:24 +0530 [thread overview]
Message-ID: <c3e6c8b2e10ed9e7ededead85ea5ec4f@mail.gmail.com> (raw)
In-Reply-To: <4D60A8DE.1000805@ti.com>
> Better might be to introduce and use CHIP_GE_OMAP3630ES1 in hwmod
> structs in that case - that should ease things up. but the ES1 story
> should be fixed I guess.
>
>
> > What do people think of this?
>
>
> + Anand from commit b0a1a6ce0597662c06f970643da60b8ebb5cdd1c which
> introduced the code in id.c to hear his views as well.
There's one instance where we needed to distinguish between ES1.0 and
all later revs of the 36xx - this was in commit 58dcfb3a0f
(omap: 3630: disable TLL SAR on 3630 ES1).
I chose to pick the same approach that was done for 3430 ES3.0 and below.
We keep two "struct powerdomain core_3xx*pwrdm" instances in
mach-omap2/powerdomains34xx.h with TLL SAR disabled in one. I couldn't
think up a better way to handle this at the time.
- Anand
next prev parent reply other threads:[~2011-02-21 5:50 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 12:01 [PATCH 00/19] OMAP3+: introduce SR class 1.5 Nishanth Menon
2011-02-19 12:01 ` [PATCH 01/19] omap3: hwmod: add smartreflex irqs Nishanth Menon
2011-03-02 23:48 ` Kevin Hilman
2011-03-03 0:43 ` Nishanth Menon
2011-02-19 12:01 ` [PATCH 02/19] omap3630: hwmod: sr: enable for higher ES Nishanth Menon
2011-02-19 13:22 ` Vishwanath Sripathy
2011-02-20 5:26 ` Nishanth Menon
2011-02-20 5:38 ` do we need CHIP_GE_OMAP3630ES1in .oc? (was Re: [PATCH 02/19] omap3630: hwmod: sr: enable for higher ES) Nishanth Menon
2011-02-21 5:50 ` Anand Gadiyar [this message]
2011-02-19 12:01 ` [PATCH 03/19] omap3+: voltage: remove initial voltage Nishanth Menon
2011-02-19 13:24 ` Vishwanath Sripathy
2011-02-20 5:12 ` Nishanth Menon
2011-02-23 6:54 ` Vishwanath Sripathy
2011-02-23 8:18 ` Menon, Nishanth
2011-02-23 8:59 ` Vishwanath Sripathy
2011-02-23 9:08 ` Menon, Nishanth
2011-03-02 23:52 ` Kevin Hilman
2011-03-03 0:35 ` Nishanth Menon
2011-03-03 0:53 ` Kevin Hilman
2011-02-19 12:01 ` [PATCH 04/19] omap3+: voltage: remove spurious pr_notice for debugfs Nishanth Menon
2011-02-19 12:01 ` [PATCH 05/19] omap3+: voltage: use IS_ERR_OR_NULL Nishanth Menon
2011-02-19 12:01 ` [PATCH 06/19] omap3+: voltage: use volt_data pointer instead values Nishanth Menon
2011-02-24 5:28 ` Gulati, Shweta
2011-02-24 8:29 ` Gulati, Shweta
2011-02-24 17:22 ` Menon, Nishanth
2011-02-19 12:01 ` [PATCH 07/19] omap3+: voltage: add transdone apis Nishanth Menon
2011-02-19 12:01 ` [PATCH 08/19] omap3+: sr: make notify independent of class Nishanth Menon
2011-03-03 0:05 ` Kevin Hilman
2011-02-19 12:01 ` [PATCH 09/19] omap3+: sr: introduce class init,deinit and priv data Nishanth Menon
2011-03-03 0:08 ` Kevin Hilman
2011-03-03 0:41 ` Nishanth Menon
2011-03-03 0:57 ` Kevin Hilman
2011-03-03 1:22 ` Nishanth Menon
2011-02-19 12:01 ` [PATCH 10/19] omap3+: sr: fix cosmetic indentation Nishanth Menon
2011-03-03 0:09 ` Kevin Hilman
2011-02-19 12:01 ` [PATCH 11/19] omap3+: sr: call handler with interrupt disabled Nishanth Menon
2011-03-03 0:11 ` Kevin Hilman
2011-03-03 0:46 ` Nishanth Menon
2011-02-19 12:01 ` [PATCH 12/19] omap3+: sr: disable interrupt by default Nishanth Menon
2011-03-03 0:15 ` Kevin Hilman
2011-03-03 0:26 ` Nishanth Menon
2011-03-03 0:59 ` Kevin Hilman
2011-03-03 1:23 ` Nishanth Menon
2011-02-19 12:01 ` [PATCH 13/19] omap3+: sr: enable/disable SR only on need Nishanth Menon
2011-02-19 12:01 ` [PATCH 14/19] omap3+: sr: introduce notifiers flags Nishanth Menon
2011-03-03 0:17 ` Kevin Hilman
2011-03-03 0:47 ` Nishanth Menon
2011-02-19 12:01 ` [PATCH 15/19] omap3+: sr: introduce notifier_control Nishanth Menon
2011-02-19 13:40 ` Vishwanath Sripathy
2011-02-20 4:50 ` Nishanth Menon
2011-02-23 6:46 ` Vishwanath Sripathy
2011-02-23 8:14 ` Menon, Nishanth
2011-02-19 12:01 ` [PATCH 16/19] omap3+: sr: disable spamming interrupts Nishanth Menon
2011-03-03 0:21 ` Kevin Hilman
2011-02-19 12:01 ` [PATCH 17/19] omap3+: sr: make enable path use volt_data pointer Nishanth Menon
2011-02-19 12:01 ` [PATCH 18/19] omap3630+: sr: add support for class 1.5 Nishanth Menon
2011-03-01 9:53 ` Gulati, Shweta
2011-03-01 10:17 ` Menon, Nishanth
2011-03-01 12:20 ` Gulati, Shweta
2011-02-19 12:01 ` [PATCH 19/19] omap3430: sr: class3: restrict cpu to run on Nishanth Menon
2011-03-03 0:33 ` [PATCH 00/19] OMAP3+: introduce SR class 1.5 Kevin Hilman
2011-03-03 0:37 ` Nishanth Menon
2011-03-03 1:00 ` Kevin Hilman
2011-03-03 1:30 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3e6c8b2e10ed9e7ededead85ea5ec4f@mail.gmail.com \
--to=gadiyar@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox