From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: RE: [PATCH 4/5] ARM: scu: Move register defines to header file Date: Fri, 4 Feb 2011 16:16:07 +0530 Message-ID: References: <1295859080-15259-1-git-send-email-santosh.shilimkar@ti.com> <1295859080-15259-5-git-send-email-santosh.shilimkar@ti.com> <20110125114635.GB13300@n2100.arm.linux.org.uk> <236d45e400a960cc3b32db538b3a79ae@mail.gmail.com> <20110125121655.GD13300@n2100.arm.linux.org.uk> <4534e82bf14eeea9f96769df760df5ae@mail.gmail.com> <20110125125656.GG13300@n2100.arm.linux.org.uk> <20110125130422.GH13300@n2100.arm.linux.org.uk> <20110125130611.GA15663@n2100.arm.linux.org.uk> <627ff975140c8e4afbad281105b29d35@mail.gmail.com> <20110204104113.GD15004@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from na3sys009aog102.obsmtp.com ([74.125.149.69]:52214 "EHLO na3sys009aog102.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739Ab1BDKqJ (ORCPT ); Fri, 4 Feb 2011 05:46:09 -0500 Received: by yie16 with SMTP id 16so893577yie.34 for ; Fri, 04 Feb 2011 02:46:07 -0800 (PST) In-Reply-To: <20110204104113.GD15004@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: catalin.marinas@arm.com, linus.ml.walleij@gmail.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ccross@android.com > -----Original Message----- > From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk] > Sent: Friday, February 04, 2011 4:11 PM > To: Santosh Shilimkar > Cc: catalin.marinas@arm.com; linus.ml.walleij@gmail.com; linux- > omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > ccross@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Tue, Jan 25, 2011 at 11:53:35PM +0530, Santosh Shilimkar wrote: > > After fixing the 3rd version for base address break, I was able to > > use this patch and test it. Seems to work. SMC related stuff can > > be ignored because OMAP4 ES1.0 doesn't have functional PM hardware > > support. > > I think I'd prefer to do as the other functions do, and pass in the > scu base address from the platform code. It's potentially more > efficient for platforms which have a fixed SCU base address. Ok. I can fix that