From: Felipe Balbi <me@felipebalbi.com>
To: Madhusudhan Chikkature Rajashekar <madhu.cr@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Subject: RE: [RFC/PATCH] BQ27000/BQ27200 battery monitoring driver for OMAP34xx
Date: Mon, 28 Apr 2008 06:47:09 -0500 [thread overview]
Message-ID: <c8e665543c8e8ca9a6717408897e69ac@felipebalbi.com> (raw)
In-Reply-To: <003501c8a924$db298fb0$018918ac@ent.ti.com>
On Mon, 28 Apr 2008 17:11:51 +0530, "Madhusudhan Chikkature Rajashekar"
<madhu.cr@ti.com> wrote:
> Hi Felipe,
>
> Thanks for the comments. I will fix them and resend the patch.
>
> Please note my view on the below point.
>
>> > - pdev = platform_device_alloc("omap-bq2700-battery", id);
>> > + pdev = platform_device_alloc("bq27000-bat", id);
>>
>> do you really need to change the name here?
>> It seems that this change doesn't belong to this patch.
>
> I will make this as a separate patch.As BQ27000 chip is not omap
specific,
> I guess the above name is not correct. Hence I intend to make that
change.
Ok, works for me :-)
I guess bq2700-battery is ok, just remove omap- from the previous name??
--
Best Regards,
Felipe Balbi
http://felipebalbi.com
me@felipebalbi.com
next prev parent reply other threads:[~2008-04-28 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 9:31 [RFC/PATCH] BQ27000/BQ27200 battery monitoring driver for OMAP34xx Madhusudhan Chikkature Rajashekar
2008-04-25 10:49 ` Felipe Balbi
2008-04-28 11:41 ` Madhusudhan Chikkature Rajashekar
2008-04-28 11:47 ` Felipe Balbi [this message]
2008-04-29 8:50 ` Madhusudhan Chikkature Rajashekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8e665543c8e8ca9a6717408897e69ac@felipebalbi.com \
--to=me@felipebalbi.com \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox