From: "Durrant, Paul" <xadimgnik@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net, pabeni@redhat.com
Cc: edumazet@google.com, netdev@vger.kernel.org,
ulli.kroll@googlemail.com, linus.walleij@linaro.org,
mlindner@marvell.com, stephen@networkplumber.org, nbd@nbd.name,
john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, matthias.bgg@gmail.com,
grygorii.strashko@ti.com, wei.liu@kernel.org, paul@xen.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH net-next v2 01/15] eth: remove copies of the NAPI_POLL_WEIGHT define
Date: Fri, 29 Apr 2022 09:11:54 +0100 [thread overview]
Message-ID: <c962f441-05b8-8aa1-5186-c85251f3e0ba@gmail.com> (raw)
In-Reply-To: <20220428212323.104417-2-kuba@kernel.org>
On 28/04/2022 22:23, Jakub Kicinski wrote:
> Defining local versions of NAPI_POLL_WEIGHT with the same
> values in the drivers just makes refactoring harder.
>
> Drop the special defines in a bunch of drivers where the
> removal is relatively simple so grouping into one patch
> does not impact reviewability.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: ulli.kroll@googlemail.com
> CC: linus.walleij@linaro.org
> CC: mlindner@marvell.com
> CC: stephen@networkplumber.org
> CC: nbd@nbd.name
> CC: john@phrozen.org
> CC: sean.wang@mediatek.com
> CC: Mark-MC.Lee@mediatek.com
> CC: matthias.bgg@gmail.com
> CC: grygorii.strashko@ti.com
> CC: wei.liu@kernel.org
> CC: paul@xen.org
> CC: prabhakar.mahadev-lad.rj@bp.renesas.com
> CC: linux-arm-kernel@lists.infradead.org
> CC: linux-mediatek@lists.infradead.org
> CC: linux-omap@vger.kernel.org
> CC: xen-devel@lists.xenproject.org
> ---
> drivers/net/ethernet/cortina/gemini.c | 4 +---
> drivers/net/ethernet/marvell/skge.c | 3 +--
> drivers/net/ethernet/marvell/sky2.c | 3 +--
> drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 +--
> drivers/net/ethernet/ti/davinci_emac.c | 3 +--
> drivers/net/ethernet/ti/netcp_core.c | 5 ++---
> drivers/net/xen-netback/interface.c | 3 +--
> 7 files changed, 8 insertions(+), 16 deletions(-)
>
xen-netback patch...
Reviewed-by: Paul Durrant <paul@xen.org>
next prev parent reply other threads:[~2022-04-29 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220428212323.104417-1-kuba@kernel.org>
2022-04-28 21:23 ` [PATCH net-next v2 01/15] eth: remove copies of the NAPI_POLL_WEIGHT define Jakub Kicinski
2022-04-29 8:11 ` Durrant, Paul [this message]
2022-04-28 21:23 ` [PATCH net-next v2 03/15] eth: cpsw: remove a copy " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c962f441-05b8-8aa1-5186-c85251f3e0ba@gmail.com \
--to=xadimgnik@gmail.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mlindner@marvell.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@xen.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sean.wang@mediatek.com \
--cc=stephen@networkplumber.org \
--cc=ulli.kroll@googlemail.com \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox