Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	Conor Dooley <conor+dt@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	Andreas Kemnade <andreas@kemnade.info>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-omap@vger.kernel.org, Roger Quadros <rogerq@kernel.org>,
	Lee Jones <lee@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: syscon: Disallow simple-bus with syscon
Date: Mon, 8 Jun 2026 14:25:49 +0200	[thread overview]
Message-ID: <ccc81b28-8949-48df-a345-ef392150fcd0@kernel.org> (raw)
In-Reply-To: <178060921244.1298375.8605331769477177888.robh@kernel.org>

On 04/06/2026 23:40, Rob Herring (Arm) wrote:
> 
> On Sun, 31 May 2026 13:04:05 +0200, Krzysztof Kozlowski wrote:
>> "syscon" is a system controller with registers having their own
>> functions, thus not really a trivial MMIO simple bus.  "simple-bus" on
>> the other hand is just a bus on which multiple devices sit and the
>> "simple" means no functions are allowed here.
>>
>> Combination of both "syscon" and "simple-bus" is abuse of DT for easier
>> instantiating of Linux device drivers so add a schema to disallow that.
>>
>> Unfortunately there are a few old cases of that patterns, so add
>> exceptions:
>>
>> 1. "cznic,turris1x-cpld" and "img,pistachio-cr-periph" are already used
>>    in upstream DTS.
>>
>> 2. TI has several DTSI with a child of SCM device (e.g. "ti,am3-scm")
>>    using "syscon" and "simple-bus" but without a dedicated compatible
>>    documented anywhere.  Add new compatibles for such cases.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>>  .../bindings/mfd/syscon-common.yaml           | 27 +++++++++++++++++--
>>  1 file changed, 25 insertions(+), 2 deletions(-)
>>
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>

Thanks for ack, but this is partial patch on top of my earlier work
which I forgot to squash here. I will send a v2 without the ack.

Best regards,
Krzysztof

      reply	other threads:[~2026-06-08 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-31 11:04 [PATCH 1/2] dt-bindings: mfd: syscon: Disallow simple-bus with syscon Krzysztof Kozlowski
2026-05-31 11:04 ` [PATCH 2/2] ARM: dts: ti: Add specific compatibles for SCM conf nodes Krzysztof Kozlowski
2026-06-03 15:10   ` Andreas Kemnade
2026-06-08 13:51     ` Krzysztof Kozlowski
2026-06-04 21:40 ` [PATCH 1/2] dt-bindings: mfd: syscon: Disallow simple-bus with syscon Rob Herring (Arm)
2026-06-08 12:25   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccc81b28-8949-48df-a345-ef392150fcd0@kernel.org \
    --to=krzk@kernel.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox