From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v3 2/9] hwmon: (core) New hwmon registration API Date: Fri, 12 Aug 2016 05:40:25 -0700 Message-ID: References: <1469417552-9749-1-git-send-email-linux@roeck-us.net> <1469417552-9749-3-git-send-email-linux@roeck-us.net> <57AD85C4.5020409@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <57AD85C4.5020409@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Keerthy , Jean Delvare Cc: Jonathan Cameron , Zhang Rui , Eduardo Valentin , Punit Agrawal , linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-omap@vger.kernel.org" , "R, Vignesh" List-Id: linux-omap@vger.kernel.org On 08/12/2016 01:16 AM, Keerthy wrote: > On Monday 25 July 2016 09:02 AM, Guenter Roeck wrote: >> Up to now, each hwmon driver has to implement its own sysfs attributes. >> This requires a lot of template code, and distracts from the driver's core >> function to read and write chip registers. >> >> To be able to reduce driver complexity, move sensor attribute handling >> and thermal zone registration into hwmon core. By using the new API, >> driver code and data size is typically reduced by 20-70%, depending >> on driver complexity and the number of sysfs attributes supported. >> >> With this patch, the new API only supports thermal sensors. Support for >> other sensor types will be added with subsequent patches. >> > Hi Guenter, > > Seems like this patch introduces a cycling dependency between > thermal_sys and hwmon: > > DEPMOD 4.8.0-rc1-next-20160811-00001-g2f84cf7854e7 > depmod: ERROR: Found 2 modules in dependency cycles! > depmod: ERROR: Cycle detected: hwmon -> thermal_sys -> hwmon > > As reported by R, Vignesh . > Hmm ... interesting. Thanks for letting me know. I'll have to think about that. Guenter