From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH V4 2/3] thermal/drivers/cpu_cooling: Unregister with the policy Date: Fri, 28 Jun 2019 11:57:57 +0200 Message-ID: References: <20190627210209.32600-1-daniel.lezcano@linaro.org> <20190627210209.32600-2-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Viresh Kumar , "Rafael J. Wysocki" , Eduardo Valentin , Linux Kernel Mailing List , Sudeep Holla , Amit Daniel Kachhap , Javi Merino , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Keerthy , "open list:CPU FREQUENCY DRIVERS - ARM BIG LITTLE" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list:TI BANDG List-Id: linux-omap@vger.kernel.org On 28/06/2019 11:12, Rafael J. Wysocki wrote: > On Thu, Jun 27, 2019 at 11:02 PM Daniel Lezcano > wrote: >> >> Currently the function cpufreq_cooling_register() returns a cooling >> device pointer which is used back as a pointer to call the function >> cpufreq_cooling_unregister(). Even if it is correct, it would make >> sense to not leak the structure inside a cpufreq driver and keep the >> code thermal code self-encapsulate. Moreover, that forces to add an >> extra variable in each driver using this function. >> >> Instead of passing the cooling device to unregister, pass the policy. >> >> Because the cpufreq_cooling_unregister() function uses the policy to >> unregister itself. The only purpose of the cooling device pointer is >> to unregister the cpu cooling device. >> >> As there is no more need of this pointer, remove it. >> >> Signed-off-by: Daniel Lezcano >> Acked-by: Viresh Kumar > > This doesn't apply for me. > > Care to rebase it on top of the Linus' tree? Sure but the patch depends on 1/3 which is in bleeding edge. Shall I rebase the 3 patches on v5.2-rc6 and resend ? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog