Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: "Víctor Manuel Jáquez Leal" <vjaquez@igalia.com>
To: Omar Ramirez Luna <omar.ramirez@ti.com>,
	Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-omap@vger.kernel.org,
	Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH 0/4] staging: tidspbridge: remove desgin-by-contract macros
Date: Tue,  7 Feb 2012 00:39:33 +0100	[thread overview]
Message-ID: <cover.1328563908.git.vjaquez@igalia.com> (raw)

These patches removes all the design-by-contract (DBC) macros in the
tidspbridge.

Also it removes the config option CONFIG_TIDSPBRIDGE_DEBUG.

The patches are applied above these submitted patches:
http://thread.gmane.org/gmane.linux.kernel/1246081

The main reasons to remove these DBC macros are

* The kernel in general doesn't follow the DBC approach

* They only provide a needless verbosity, since they are available only
  when CONFIG_TIDSPBRIDGE_DEBUG is enabled. If they were useful they
  should be left for the dynamic debugging always. So, if they are not
  used, is dead code at the end, and should be removed.

* Deleting them means less code to maintain

As the Emperor Joseph II told to Mozart in the motion picture Amadeus:
"It's quality work. And there are simply too many notes, that's
all. Just cut a few and it will be perfect."

vmjl


Víctor Manuel Jáquez Leal (4):
  staging: tidspbridge: remove DBC_ENSURE and DBC_REQUIRED
  staging: tidspbridge: remove DBC_ASSERT macro
  staging: tidspbridge: remove dbc.h
  staging: tidspbridge: remove CONFIG_TIDSPBRIDGE_DEBUG

 drivers/staging/tidspbridge/Kconfig                |    6 -
 drivers/staging/tidspbridge/core/chnl_sm.c         |   34 +-----
 drivers/staging/tidspbridge/core/dsp-clock.c       |    3 -
 drivers/staging/tidspbridge/core/io_sm.c           |   29 +----
 drivers/staging/tidspbridge/core/msg_sm.c          |    3 -
 drivers/staging/tidspbridge/core/tiomap3430.c      |    9 --
 drivers/staging/tidspbridge/core/tiomap3430_pwr.c  |    1 -
 drivers/staging/tidspbridge/core/tiomap_io.c       |   18 ---
 drivers/staging/tidspbridge/gen/uuidutil.c         |    7 -
 .../staging/tidspbridge/include/dspbridge/dbc.h    |   46 -------
 .../staging/tidspbridge/include/dspbridge/io_sm.h  |    2 -
 drivers/staging/tidspbridge/pmgr/chnl.c            |   19 ---
 drivers/staging/tidspbridge/pmgr/cmm.c             |   68 +----------
 drivers/staging/tidspbridge/pmgr/cod.c             |   74 -----------
 drivers/staging/tidspbridge/pmgr/dbll.c            |  113 +-----------------
 drivers/staging/tidspbridge/pmgr/dev.c             |  132 --------------------
 drivers/staging/tidspbridge/pmgr/dmm.c             |   14 --
 drivers/staging/tidspbridge/pmgr/dspapi.c          |    7 -
 drivers/staging/tidspbridge/pmgr/io.c              |   17 ---
 drivers/staging/tidspbridge/pmgr/msg.c             |   17 ---
 drivers/staging/tidspbridge/rmgr/dbdcd.c           |   88 -------------
 drivers/staging/tidspbridge/rmgr/disp.c            |   44 -------
 drivers/staging/tidspbridge/rmgr/drv.c             |   48 -------
 drivers/staging/tidspbridge/rmgr/drv_interface.c   |    6 -
 drivers/staging/tidspbridge/rmgr/dspdrv.c          |    5 -
 drivers/staging/tidspbridge/rmgr/mgr.c             |   36 ------
 drivers/staging/tidspbridge/rmgr/nldr.c            |   71 -----------
 drivers/staging/tidspbridge/rmgr/node.c            |   98 ---------------
 drivers/staging/tidspbridge/rmgr/proc.c            |   91 --------------
 drivers/staging/tidspbridge/rmgr/rmm.c             |   36 ------
 drivers/staging/tidspbridge/rmgr/strm.c            |   86 +-------------
 31 files changed, 11 insertions(+), 1217 deletions(-)
 delete mode 100644 drivers/staging/tidspbridge/include/dspbridge/dbc.h

-- 
1.7.8.3

             reply	other threads:[~2012-02-06 23:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 23:39 Víctor Manuel Jáquez Leal [this message]
2012-02-06 23:39 ` [PATCH 1/4] staging: tidspbridge: remove DBC_ENSURE and DBC_REQUIRED Víctor Manuel Jáquez Leal
2012-02-06 23:39 ` [PATCH 2/4] staging: tidspbridge: remove DBC_ASSERT macro Víctor Manuel Jáquez Leal
2012-02-06 23:39 ` [PATCH 3/4] staging: tidspbridge: remove dbc.h Víctor Manuel Jáquez Leal
2012-02-06 23:39 ` [PATCH 4/4] staging: tidspbridge: remove CONFIG_TIDSPBRIDGE_DEBUG Víctor Manuel Jáquez Leal
2012-02-07  0:02 ` [PATCH 0/4] staging: tidspbridge: remove desgin-by-contract macros Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1328563908.git.vjaquez@igalia.com \
    --to=vjaquez@igalia.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=felipe.contreras@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=omar.ramirez@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox