From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Colin King <colin.king@canonical.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: twl6040: make pointer dmic_codec_dev static
Date: Tue, 12 Jun 2018 10:46:56 +0300 [thread overview]
Message-ID: <d0355575-feb2-a1fe-242a-57acf52bad1e@ti.com> (raw)
In-Reply-To: <20180606093504.30255-1-colin.king@canonical.com>
Hi,
On 2018-06-06 12:35, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer dmic_codec_dev is local to the source and does not need
> to be in global scope, so make it static.
>
> Cleans up sparse warning:
> warning: symbol 'dmic_codec_dev' was not declared. Should it be static?
can you change the subject to:
ASoC: omap-abe-twl6040: make pointer dmic_codec_dev static
With that change:
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/omap/omap-abe-twl6040.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/omap/omap-abe-twl6040.c b/sound/soc/omap/omap-abe-twl6040.c
> index 15ccbf479c96..d5ae9eb8c756 100644
> --- a/sound/soc/omap/omap-abe-twl6040.c
> +++ b/sound/soc/omap/omap-abe-twl6040.c
> @@ -40,7 +40,7 @@ struct abe_twl6040 {
> int mclk_freq; /* MCLK frequency speed for twl6040 */
> };
>
> -struct platform_device *dmic_codec_dev;
> +static struct platform_device *dmic_codec_dev;
>
> static int omap_abe_hw_params(struct snd_pcm_substream *substream,
> struct snd_pcm_hw_params *params)
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2018-06-12 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 9:35 [PATCH] ASoC: twl6040: make pointer dmic_codec_dev static Colin King
2018-06-12 7:46 ` Peter Ujfalusi [this message]
2018-06-18 12:00 ` Applied "ASoC: twl6040: make pointer dmic_codec_dev static" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0355575-feb2-a1fe-242a-57acf52bad1e@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=jarkko.nikula@bitmer.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox