From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67483C7EE24 for ; Sat, 13 May 2023 18:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231506AbjEMSje (ORCPT ); Sat, 13 May 2023 14:39:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjEMSjd (ORCPT ); Sat, 13 May 2023 14:39:33 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC1AC2139 for ; Sat, 13 May 2023 11:39:28 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-965fc25f009so1769517766b.3 for ; Sat, 13 May 2023 11:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684003167; x=1686595167; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tJgRipBTIMb9CKVptB0CK8vcEy1PL4DIIOTmSIIgPL0=; b=iG2e9xty+mu13wsk5ZZM2QaivT8V52G8/Af/PifVYBtLEzIXHIe06u/elBe1sr0Djd aSAji3yS5LgcoFTRpqxzNPwTOm8stv9rdWo/6ANeKzHlZDreAKLVD94/cUt0xVM5gLB8 bh7XvLe2HRcyEKASv5Vwswa/IKzWZ5qAGsa72ikRD4XhA6/QbLsuMGoMFSlXLgwpobcS urJPJ8tAzXUdsO8gn+IGWMMXRX6q09fLGsj1T2s9mBTSuGT/efeJ8ugbCVhoFSejB/Tb RpUjM7gZkem4Ep8SQfrahiNgJY90jVtc5ycgRjkbFJsS6zh34P015AyayIO3TXKXcG5W 299w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684003167; x=1686595167; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tJgRipBTIMb9CKVptB0CK8vcEy1PL4DIIOTmSIIgPL0=; b=ZoHAKCNqoAWZRrNNf3iDaAIW88iL9rn4pzAw5INiIPSMEcwzKE9aSsNby2mLGGMOcK MogMLycP82DcpZRHhvO4mweMfa923MPSih1UZo9lLIsjGDTWI+Q8DE8/Ztt5/sUfT725 2+pFPVkr720pU16yJoOcmg1iMhzcnZOmbIFA3vCHvbZ7Dta5/JQWlRnh9Ph4n7MGz/MO yb2K4mYTME37StRCt5PfOZTaDWq2DyOaUKUmQ0QmMvZl+sNyDKpxv2nxblZDQOtpr/x7 u+fzrPaWP/kfCvSBSwoioBGLQeQ2X4jWzje9w6yOa7R2QjgX2P5QiMIvZOw7dnmqn/7i wYkg== X-Gm-Message-State: AC+VfDwWDKDHbZf05O4aRzEkVn+rYq5hQxHuupzWJSlxYdFbieC1d5AM npEnjEfIFU8sYPZP8bw2DkjaXQ== X-Google-Smtp-Source: ACHHUZ7KQIKKSFZzxRVxqQy6v2UvaVPHdQTePpga0/dLKovt2/RDIklcz0rqo0618m3DIDXIpqarsw== X-Received: by 2002:a17:906:db0d:b0:94a:35d1:59a with SMTP id xj13-20020a170906db0d00b0094a35d1059amr23656859ejb.14.1684003167395; Sat, 13 May 2023 11:39:27 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ba68:e5c9:694e:c6e4? ([2a02:810d:15c0:828:ba68:e5c9:694e:c6e4]) by smtp.gmail.com with ESMTPSA id k18-20020a17090632d200b009661f07db93sm7049268ejk.223.2023.05.13.11.39.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 May 2023 11:39:26 -0700 (PDT) Message-ID: Date: Sat, 13 May 2023 20:39:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [EXTERNAL] Re: [PATCH 3/3] arm64: defconfig: enable J721e PCIe controller Content-Language: en-US To: "Verma, Achal" , Tom Joseph , Lorenzo Pieralisi , Krzysztof Wilczy_ski , Rob Herring , Bjorn Helgaas , Catalin Marinas , Will Deacon , Bjorn Andersson , Arnd Bergmann , Geert Uytterhoeven , Dmitry Baryshkov , "N_colas F . R . A . Prado" , Mark Brown , Rafa_ Mi_ecki , Vignesh Raghavendra , Nishanth Menon , Milind Parab , Swapnil Kashinath Jakhade Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-omap@vger.kernel.org References: <20230512070510.1873171-1-a-verma1@ti.com> <20230512070510.1873171-4-a-verma1@ti.com> <13028434-f68c-cad3-056e-d319c1ec35cf@linaro.org> <3b5d7c3c-164d-0690-c2e8-2c7daec4865c@ti.com> From: Krzysztof Kozlowski In-Reply-To: <3b5d7c3c-164d-0690-c2e8-2c7daec4865c@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 13/05/2023 19:58, Verma, Achal wrote: > > Hello Krzysztof, > On 5/12/2023 12:53 PM, Krzysztof Kozlowski wrote: >> On 12/05/2023 09:05, Achal Verma wrote: >>> Enable Cadence PCIe controller and pci-j721e drivers to be built as >>> kernel modules. >> >> Why? IOW, who needs them. Please provide rationale in the commit msg. I >> am pretty sure I asked for this... >> > On TI's J7 SOCs, PCIe is composed of PCIe core from Cadence and TI > wrapper. It is desired to have J7 PCIe working on upstream kernel by > default. So to enable this I have pushed these defconfig changes. > > BTW, I am planning to hold this change until PCIe code changes (rest of > the patches in this series) gets merged. > > Please let me know if there are more concern to this. The concerns are that commit msg does not explain this. Please always provide in commit msg answer to "why you are doing this". In case of defconfig the answer to "why" is: "board foo bar with SoC baz uses it". Best regards, Krzysztof