From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>, tony@atomide.com, linux@armlinux.org.uk
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/mach-omap2: Fix refcount leak bug in omap_hwmod.c
Date: Wed, 22 Jun 2022 11:00:21 +0200 [thread overview]
Message-ID: <d3a5128e-7f1c-58e9-05fd-d467a552429f@kernel.org> (raw)
In-Reply-To: <20220618014747.4055279-1-windhl@126.com>
On 18/06/2022 03:47, Liang He wrote:
> In _init(), of_find_node_by_name() will return a node pointer with
> refcount incremented. We should use of_node_put() in fail path or
> when it is not used anymore.
>
> NOTE: As the ref will be passed from 'bus' to 'np' by the xx_lookup(),
> in normal exit path, we should call of_node_put() at the end use of 'np',
> not the end use of 'bus'.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> arch/arm/mach-omap2/omap_hwmod.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.
[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/
[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-22 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 1:47 [PATCH] arm/mach-omap2: Fix refcount leak bug in omap_hwmod.c Liang He
2022-06-22 9:00 ` Krzysztof Kozlowski [this message]
2022-06-28 4:57 ` Tony Lindgren
2022-06-28 5:51 ` Liang He
2022-06-28 6:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3a5128e-7f1c-58e9-05fd-d467a552429f@kernel.org \
--to=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox