From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>,
andre.przywara@arm.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, tony@atomide.com
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] arm/mach: Hold reference returned by of_find_xxx APIs
Date: Wed, 22 Jun 2022 10:51:32 +0200 [thread overview]
Message-ID: <d56f0c69-5c70-5539-03aa-5dd28f284a8b@kernel.org> (raw)
In-Reply-To: <20220621091937.4082422-1-windhl@126.com>
On 21/06/2022 11:19, Liang He wrote:
> In highbank_init_irq(), tegra_init_irq() and omap4_cpcap_init(),
> we should hold the reference returned by of_find_xxx APIs and
> use it to call of_node_put() for refcount balance.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> arch/arm/mach-highbank/highbank.c | 6 +++++-
> arch/arm/mach-omap2/pmic-cpcap.c | 5 ++++-
> arch/arm/mach-tegra/irq.c | 6 +++++-
> 3 files changed, 14 insertions(+), 3 deletions(-)
Before applying the patch please check it carefully. Previous evidence
[1] suggests that not it was not even compiled.
[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-22 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 9:19 [PATCH] arm/mach: Hold reference returned by of_find_xxx APIs Liang He
2022-06-22 8:51 ` Krzysztof Kozlowski [this message]
2022-06-28 3:59 ` Tony Lindgren
2022-06-28 4:05 ` Liang He
2022-06-28 16:16 ` Russell King (Oracle)
2022-06-29 8:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d56f0c69-5c70-5539-03aa-5dd28f284a8b@kernel.org \
--to=krzk@kernel.org \
--cc=andre.przywara@arm.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).