public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Anand Gadiyar <gadiyar@ti.com>
To: Abhilash Koyamangalath <abhilash.kv@ti.com>, linux-omap@vger.kernel.org
Subject: RE: gpio126: Multiple gpio paths (2) : CAM_STROBE & SDMMC1_DAT4
Date: Tue, 22 Feb 2011 15:23:25 +0530	[thread overview]
Message-ID: <d788d25561dc676a189686737c97a95f@mail.gmail.com> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC3560870370562CF6@dbde02.ent.ti.com>

Koyamangalath, Abhilash wrote:
> There is this boot-time message on the am3517evm (and possibly
> other omap 35xx based boards as well)
> [    0.000000] _omap_mux_init_gpio: Multiple gpio paths
>  (2) for gpio126
> I realized that this happens due to dual mappings for
> gpio_126 in arch/arm/mach-omap2/mux34xx.c:
>
> static struct omap_mux __initdata omap3_muxmodes[] = {
> :
> _OMAP3_MUXENTRY(CAM_STROBE, 126,
>                 "cam_strobe", NULL, NULL, NULL,
>                 "gpio_126", "hw_dbg11", NULL, "safe_mode"),
> :
> _OMAP3_MUXENTRY(SDMMC1_DAT4, 126,
>                 "sdmmc1_dat4", NULL, "sim_io", NULL,
>                 "gpio_126", NULL, NULL, "safe_mode"),
> :
> #if defined(CONFIG_OMAP_MUX) &&
> defined(CONFIG_OMAP_PACKAGE_CBB) static struct omap_mux
> __initdata omap3_cbb_subset[] = {
> :
>        _OMAP3_MUXENTRY(CAM_STROBE, 126,
>                 "cam_strobe", NULL, NULL, NULL,
>                 "gpio_126", NULL, NULL, "safe_mode"),
>
> Removing one instance of CAM_STROBE from omap3_muxmodes rids us
> of this (pr_info) message and should be fine as this is defined in
> omap3_xxx_subset as well. But I'm concerned if this would
> break things
> on the other omap3 boards?
>
> For completeness, I've listed my patch (only for the CBB
> package) below
> (this also modifies the Mode 5 value of CAM_STROBE from NULL
> to hw_dbg11
> in omap3_cbb_subset, which is incorrect right now); please comment:
>
> ---

The GPIO 126 signal is available on two pads of that package.
You will therefore need to update the caller to use
omap_mux_init_signal specifying the full name as "cam_strobe.gpio_126"
or equivalent.

I'm not sure if you can do something similar using omap_mux_init_gpio.

Dropping an entry from the table is not the right way to go.

- Anand

  reply	other threads:[~2011-02-22  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-21 13:58 gpio126: Multiple gpio paths (2) : CAM_STROBE & SDMMC1_DAT4 Koyamangalath, Abhilash
2011-02-22  9:53 ` Anand Gadiyar [this message]
2011-02-24 21:19   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d788d25561dc676a189686737c97a95f@mail.gmail.com \
    --to=gadiyar@ti.com \
    --cc=abhilash.kv@ti.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox