From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH v4 14/16] mtd: onenand: omap2: Configure driver from DT Date: Wed, 15 Nov 2017 16:41:39 +0200 Message-ID: References: <20171111211206.465pgorrjp3eyix6@lenoch> <20171111212742.m5t4rf5k47kikouu@lenoch> <27bb610f-b30a-cd4c-ccd5-06c0d9e205b7@ti.com> <20171115105357.3jkk5eyxst5limj3@lenoch> <20171115112028.b7sbjkmwnu2uzpey@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171115112028.b7sbjkmwnu2uzpey@lenoch> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Ladislav Michl Cc: Boris Brezillon , Tony Lindgren , Peter Ujfalusi , Kyungmin Park , linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 15/11/17 13:20, Ladislav Michl wrote: > On Wed, Nov 15, 2017 at 01:04:22PM +0200, Roger Quadros wrote: >> On 15/11/17 12:53, Ladislav Michl wrote: > [snip] >>> of_property_read_u32 will fail then, so I do not think it is worth adding >>> explicit test for NULL here. >>> >> >> But the error message would be wrong in that case. >> I'm trying to tackle the case where driver was probed using legacy methods >> where device tree/node isn't present. > > But how could we ever get there in that case? platform_device_register is > removed just one patch later. > > Of course we should add: > depends on (OF && GPIOLIB) || COMPILE_TEST > to the Kconfig > OK. -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/