From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
David Miller <davem@davemloft.net>,
u.kleine-koenig@pengutronix.de
Cc: mugunthanvnm@ti.com, linux-omap@vger.kernel.org,
netdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log
Date: Wed, 27 Jul 2016 01:06:55 +0300 [thread overview]
Message-ID: <e2e470ef-b4db-e13e-c9d6-4083a3ad9f2d@linaro.org> (raw)
In-Reply-To: <4c8afcb9-f7a9-4db3-e923-48dca5cacc3c@ti.com>
On 26.07.16 17:26, Grygorii Strashko wrote:
> + CC: Ivan
>
> On 07/26/2016 05:09 PM, Grygorii Strashko wrote:
>> On 07/26/2016 03:57 AM, David Miller wrote:
>>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>> Date: Mon, 25 Jul 2016 11:54:45 +0200
>>>
>>>> Such a big dump of register values is hardly useful on a production
>>>> system.
>>>>
>>>> Another downside of the now removed functions is that calling
>>>> emac_dump_regs resulted in at least 87 calls to dev_info while holding a
>>>> spinlock and having irqs off which is a big source of latency.
>>>>
>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>
>>> Applied.
>>>
>>
>> :( To be honest I was really enjoyed using cpdma_ctlr_dump()
>> for debug purposed during the past few weeks in cpsw where I've added
>> calls to this func manually. And I even thinking about adding debug_fs
>> entry for the same :(
>>
>> Pretty fast merge :(
At least, partly, for channel stats, for cpsw, I can use ethtool.
But ctrl_dump()... the function would be better to leave, redundant calls can be
removed from davinci_emac.
>>
>>
>
>
--
Regards,
Ivan Khoronzhuk
prev parent reply other threads:[~2016-07-26 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 9:54 [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log Uwe Kleine-König
2016-07-26 0:57 ` David Miller
2016-07-26 14:09 ` Grygorii Strashko
2016-07-26 14:26 ` Grygorii Strashko
2016-07-26 22:06 ` Ivan Khoronzhuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e470ef-b4db-e13e-c9d6-4083a3ad9f2d@linaro.org \
--to=ivan.khoronzhuk@linaro.org \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).