From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Khoronzhuk Subject: Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log Date: Wed, 27 Jul 2016 01:06:55 +0300 Message-ID: References: <1469440485-19889-1-git-send-email-u.kleine-koenig@pengutronix.de> <20160725.175705.820422537273157170.davem@davemloft.net> <4c8afcb9-f7a9-4db3-e923-48dca5cacc3c@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <4c8afcb9-f7a9-4db3-e923-48dca5cacc3c@ti.com> Sender: netdev-owner@vger.kernel.org To: Grygorii Strashko , David Miller , u.kleine-koenig@pengutronix.de Cc: mugunthanvnm@ti.com, linux-omap@vger.kernel.org, netdev@vger.kernel.org, kernel@pengutronix.de List-Id: linux-omap@vger.kernel.org On 26.07.16 17:26, Grygorii Strashko wrote: > + CC: Ivan > > On 07/26/2016 05:09 PM, Grygorii Strashko wrote: >> On 07/26/2016 03:57 AM, David Miller wrote: >>> From: Uwe Kleine-K=F6nig >>> Date: Mon, 25 Jul 2016 11:54:45 +0200 >>> >>>> Such a big dump of register values is hardly useful on a productio= n >>>> system. >>>> >>>> Another downside of the now removed functions is that calling >>>> emac_dump_regs resulted in at least 87 calls to dev_info while hol= ding a >>>> spinlock and having irqs off which is a big source of latency. >>>> >>>> Signed-off-by: Uwe Kleine-K=F6nig >>> >>> Applied. >>> >> >> :( To be honest I was really enjoyed using cpdma_ctlr_dump() >> for debug purposed during the past few weeks in cpsw where I've adde= d >> calls to this func manually. And I even thinking about adding debug_= fs >> entry for the same :( >> >> Pretty fast merge :( At least, partly, for channel stats, for cpsw, I can use ethtool. But ctrl_dump()... the function would be better to leave, redundant cal= ls can be removed from davinci_emac. >> >> > > --=20 Regards, Ivan Khoronzhuk