From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69499C64E8A for ; Mon, 30 Nov 2020 09:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02E5920855 for ; Mon, 30 Nov 2020 09:33:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="duQZ9M9x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726498AbgK3JdA (ORCPT ); Mon, 30 Nov 2020 04:33:00 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:44890 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgK3JdA (ORCPT ); Mon, 30 Nov 2020 04:33:00 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0AU9VA4X033975; Mon, 30 Nov 2020 03:31:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1606728670; bh=FN32bD3RxP2OJReQ02Kv5gT9peBg8Tvy2u0Ql8xRkG4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=duQZ9M9x8GO6hkSzph+4i3TrB3Rrp/gJDoZoksRHhAZkFR+GnT7kKr3Vs+LrS83V5 +GcrIVBR2MQDOWvEKKwIIMJT4+Wc81Jvoq7Nccm2R5vSMpAF+8yrwNXGIMDJVbGbUG x0pgD9GuA3p/ViCdvhBnSBznkb704J8Qpgx7JAUA= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0AU9VAJ3119062 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Nov 2020 03:31:10 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 30 Nov 2020 03:31:09 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 30 Nov 2020 03:31:09 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0AU9V7Ij024957; Mon, 30 Nov 2020 03:31:08 -0600 Subject: Re: [PATCH] drm/omap: sdi: fix bridge enable/disable To: Aaro Koskinen CC: , Laurent Pinchart , Nikhil Devshatwar , , , Ivaylo Dimitrov References: <20201127085241.848461-1-tomi.valkeinen@ti.com> <20201128174528.GD551434@darkstar.musicnaut.iki.fi> From: Tomi Valkeinen Message-ID: Date: Mon, 30 Nov 2020 11:31:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201128174528.GD551434@darkstar.musicnaut.iki.fi> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 28/11/2020 19:45, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 27, 2020 at 10:52:41AM +0200, Tomi Valkeinen wrote: >> When the SDI output was converted to DRM bridge, the atomic versions of >> enable and disable funcs were used. This was not intended, as that would >> require implementing other atomic funcs too. This leads to: >> >> WARNING: CPU: 0 PID: 18 at drivers/gpu/drm/drm_bridge.c:708 drm_atomic_helper_commit_modeset_enables+0x134/0x268 >> >> and display not working. >> >> Fix this by using the legacy enable/disable funcs. >> >> Signed-off-by: Tomi Valkeinen >> Reported-by: Aaro Koskinen >> Fixes: 8bef8a6d5da81b909a190822b96805a47348146f ("drm/omap: sdi: Register a drm_bridge") >> Cc: stable@vger.kernel.org # v5.7+ >> Tested-by: Ivaylo Dimitrov > > Tested-by: Aaro Koskinen Thanks! I pushed this to drm-misc-fixes. Hopefully with this and Sebastian's patch N900 display now works. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki