From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Lee Jones <lee.jones@linaro.org>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 14/17 4/4] mfd: tps65910: Move an assignment in tps65910_sleepinit()
Date: Fri, 9 Mar 2018 17:42:20 +0100 [thread overview]
Message-ID: <eb3c38d5-23c3-dcf0-3772-66b917326f0a@users.sourceforge.net> (raw)
In-Reply-To: <a00bda19-c38c-6733-31e7-7e1c44eb6c6b@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 9 Mar 2018 09:19:42 +0100
Move the assignment for the local variable "dev" so that its setting
will be performed after a configuration check by this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
Lee Jones requested a resend for this patch. The change was rebased
on source files from Linux next-20180308.
drivers/mfd/tps65910.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 7e7d3d1642c6..bf16cbe6fd88 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -315,11 +315,11 @@ static int tps65910_sleepinit(struct tps65910 *tps65910,
struct device *dev;
int ret;
- dev = tps65910->dev;
-
if (!pmic_pdata->en_dev_slp)
return 0;
+ dev = tps65910->dev;
+
/* enabling SLEEP device state */
ret = tps65910_reg_set_bits(tps65910, TPS65910_DEVCTRL,
DEVCTRL_DEV_SLP_MASK);
--
2.16.2
next prev parent reply other threads:[~2018-03-09 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c5d9751e-3ae8-0b66-821a-0e7f45bb8e1c@users.sourceforge.net>
[not found] ` <a00bda19-c38c-6733-31e7-7e1c44eb6c6b@users.sourceforge.net>
2018-03-09 16:28 ` [PATCH v2 11/17] mfd: tps65910: Delete an error message for a failed memory allocation in tps65910_parse_dt() SF Markus Elfring
2018-03-09 16:37 ` [PATCH v2 12/17 2/4] mfd: tps65910: Delete an unnecessary variable initialisation in four functions SF Markus Elfring
2018-03-09 16:39 ` [PATCH v2 13/17 3/4] mfd: tps65910: Delete an unnecessary variable initialisation in tps65910_sleepinit() SF Markus Elfring
2018-03-09 16:42 ` SF Markus Elfring [this message]
2018-03-12 8:57 ` [PATCH v2 14/17 4/4] mfd: tps65910: Move an assignment " Lee Jones
2018-03-13 7:14 ` [v2 14/17 4/4] mfd: tps65910: Checking patch structures SF Markus Elfring
2018-03-13 7:56 ` Lee Jones
2018-03-09 16:49 ` [PATCH v2 16/17] mfd: twl6030-irq: Delete an error message for a failed memory allocation in twl6030_init_irq() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb3c38d5-23c3-dcf0-3772-66b917326f0a@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox